[1.16.5] Manufactory Halo cannot set recipes from Immersive Engineering with fluid buckets in them

[NielsPilgaard]

Version Information

Forge version: 1.16.5-36.1.4 Botania version: Botania-1.16.4-414 ImmersiveEngineering-1.16.5-4.2.4-134

Further Information

Link to crash log: (please use a paste site such as gist, do not attach the .txt or paste the log inline)
Steps to reproduce:

1. Obtain Manufactory Halo, 16+ Planks, 2+ Bucket of Creosote Oil
2. Crafted Treated wood with the Manufactory Halo
3. "Insert" the recipe in the Manufactory Halo
4. Observe it says you're missing materials

What I expected to happen: The craft to work

What happened instead: It did not

Note: The recipetype is from IE

{
    "type": "immersiveengineering:shaped_fluid",
    "pattern": ["www", "wbw", "www"],
    "key": {
        "w": { "tag": "minecraft:planks" },
        "b": { "tag": "forge:creosote", "amount": 1000, "type": "immersiveengineering:fluid" }
    },
    "result": { "item": "immersiveengineering:treated_wood_horizontal", "count": 8 }
}

[Kaligraphy22]

I'd like to add that this issue also happens with the paper recipe from IE. It's four sawdust and a water bucket. Same steps to reproduce.

[Nuinethir]

Chiming in here to confirm the bug on the latest July 5th build (ImmersiveEngineering-1.16.5-5.0.2-137).

I just tried the Treated Wood Planks recipe (8 planks and a bucket of creosote oil). Saved the recipe on the Manufactory Halo, but then it says "Not enough materials!". I thought it might have something to do with the bucket, so I tried the vanilla cake recipe, but that works fine. Perhaps the creosote being a non-vanilla liquid? HTH.

[artemisSystem]

I think this is because it's not an actual shaped or shapeless crafting recipe. I think it's something we'd have to support explicitly. Which makes me wonder, does this even work with our own custom recipe types? I can't test it now but i'm curious if saving a wand of the forest recipe works, for example.

[anoomolu]

Can confirm the bug on 1.19.2. fwiw Botania recipes (including the wand of the forest) seem to work fine.

[TheRealWormbo]

IE dev confirmed that the issue is unlikely to be fixed on their side, due to how deeply in vanilla code the root cause lies. (see linked issue above) Considering it's not a Botania-specific issue, I don't really think we should be providing a Botania-specific solution either.

If anyone feels adventurous, making vanilla recipe matching able to handle NBT matching properly for this kind of recipe without breaking things like "don't craft your everyday-use bow into a dispenser" might be an interesting project for a general QoL mod.