addons-vauxoo icon indicating copy to clipboard operation
addons-vauxoo copied to clipboard

[MIG] product_cost_usd: module migrated to v15.0 t#53826

Open agarzaarvizu opened this issue 2 years ago • 2 comments

This PR refers to the task#53826

  • product_cost_usd module migrated.

agarzaarvizu avatar Aug 11 '22 00:08 agarzaarvizu

@luisg123v Done, please review

cc @desdelinux

agarzaarvizu avatar Aug 11 '22 01:08 agarzaarvizu

@luisg123v Done

agarzaarvizu avatar Aug 11 '22 03:08 agarzaarvizu

@luisg123v Done

agarzaarvizu avatar Aug 18 '22 00:08 agarzaarvizu

@agarzaarvizu task ID is wrong in both title and description

luisg123v avatar Aug 19 '22 04:08 luisg123v

Hi, @luisg123v and @agarzaarvizu, I have bad news :(. I added this module in tanner_common and I had these tracebacks using it, indeed, you may see that if I do not add this module the tests are working well here

rolandojduartem avatar Aug 19 '22 23:08 rolandojduartem

@luisg123v Finally done!! Hahaha please review.

cc @rolandojduartem

agarzaarvizu avatar Aug 23 '22 05:08 agarzaarvizu

@luisg123v Done, please review

agarzaarvizu avatar Aug 26 '22 18:08 agarzaarvizu

@luisg123v Done

agarzaarvizu avatar Aug 29 '22 18:08 agarzaarvizu

Hi, @agarzaarvizu, I just want to say I'm getting this traceback, I'm just running the check_cost_and_price method.

Traceback (most recent call last): File "/.repo_requirements/odoo/odoo/models.py", line 5199, in ensure_one _id, = self._ids ValueError: too many values to unpack (expected 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last): File "/home/odoo/build/vauxoo/tanner-common/tanner_common/tests/test_product_template.py", line 35, in test_02_check_cost_and_price
self.product.product_tmpl_id.check_cost_and_price() File "/home/odoo/build/vauxoo/tanner-common/tanner_common/models/product_template.py", line 24, in check_cost_and_price
return super().check_cost_and_price() File "/home/odoo/addons-vauxoo/product_cost_usd/models/product_template.py", line 26, in check_cost_and_price
list_price = usd_seller.price File "/.repo_requirements/odoo/odoo/fields.py", line 1050, in get record.ensure_one() File "/.repo_requirements/odoo/odoo/models.py", line 5202, in ensure_one raise ValueError("Expected singleton: %s" % self) ValueError: Expected singleton: product.supplierinfo(3, 1, 2)

cc @luisg123v

rolandojduartem avatar Aug 31 '22 17:08 rolandojduartem

I've rebased this branch so tests may run

luisg123v avatar Aug 31 '22 18:08 luisg123v

@luisg123v Done

agarzaarvizu avatar Aug 31 '22 20:08 agarzaarvizu

@agarzaarvizu @luisg123v No aparece el tag del campo en la vista del Producto, sólo aparece el valor:

image

desdelinux avatar Sep 02 '22 19:09 desdelinux

@luisg123v @desdelinux Done

agarzaarvizu avatar Sep 05 '22 22:09 agarzaarvizu

LGTM

desdelinux avatar Sep 06 '22 13:09 desdelinux