VVV icon indicating copy to clipboard operation
VVV copied to clipboard

Prevent VM creation if using VirtualBox + root/sudo

Open tomjn opened this issue 5 years ago • 5 comments

In theory this prevents the creation of the VM by exiting early if the user is root. It needs further testing however

Checks

  • [ ] I've updated the changelog.
  • [ ] I've tested this PR
  • [x] This PR is for the develop branch not the stable branch.
  • [ ] This PR is complete and ready for review.

tomjn avatar Dec 04 '20 19:12 tomjn

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

update-docs[bot] avatar Dec 04 '20 19:12 update-docs[bot]

I cannot test it on linux because I did't gave sudo permission to vagrant at all.

Mte90 avatar Dec 28 '20 15:12 Mte90

sudo vagrant up in a fresh VVV checkout of this branch should be all that's needed, or running the vagrant command as root. This PR doesn't influence the guest VM

tomjn avatar Dec 28 '20 19:12 tomjn

I cannot test it because my machine block sudo on other commands.

Mte90 avatar Jan 19 '21 17:01 Mte90

I cannot test it because my machine block sudo on other commands.

I'm really curious about this... what environment actively blocks sudo by default? And if it's not a default, why would you intentionally put yourself in that position?

evertiro avatar Jun 07 '21 15:06 evertiro