Max Gautier
Max Gautier
On April 3, 2025 9:11:24 AM GMT+02:00, Kubernetes Prow Robot ***@***.***> wrote: >k8s-ci-robot left a comment (kubernetes-sigs/kubespray#11993) > >New changes are detected. LGTM label has been removed. > /lgtm Thanks...
We should actually be doing this now, but we don't exactly bother, and I think the squash workflow is one of the reasons. The work is not in vain though,...
I didn't know about that, thanks ! (Still think that we should switch the default, but that certainly helps)
/remove-lifecycle stale /lifecycle frozen
/lifecycle frozen /good-first-issue /help
/approve /release-note-edit ```release-note Fix scale.yml problems with cached IP facts ```
This is not the correct fix, this simply bypass the problem. the variable **should** be defined, => this is why you need to run the facts playbook before scaling up.
Don't disagree that we need to scrap the whole etc/hosts stuff if we can, but in that case there is no reason to patch it up, better to cleanly remove...
Also, I think the approach could make manage-offline.sh redundant (aka, just run the download tags on a non offline control node, copy the local_release_dir, done) I'm not super into that...