Max Gautier

I'm working on the last prep PR for #10701 (that PR itself is not complicated, getting in the state where we can easily use the kubernetes.core.k8s module is) > but...

So, I've taken a closer look at what we do with that variable, and IMO we should not have it in defaults to be modified: The admission_plugin which needs a...

Just one more thing and I think we'll be good: I think with that change you can remove the task "Kubeadm | Configure default cluster podnodeslector" introduced in #10607 since...

@yankay In that case it's not about defaults, but about which admission plugins needs a config file (which we use to conditionally push one)

Precisely, this is the approach I think we should **not** use. We already have a variable defining which admission plugins are enabled: kube_apiserver_enable_admission_plugins See: - name: Kubeadm | Push admission...

> Just one more thing and I think we'll be good: I think with that change you can remove the task "Kubeadm | Configure default cluster podnodeslector" introduced in #10607...

@titansmc any chance you can address the previous comment ?

Yeah, that's fine this way ! :+1: Can you just squash your commit (at least the two first) and modify the commit message ? Currently it does not reflect what...

Upstream issue (look like) : https://github.com/ansible-collections/ansible.posix/issues/502 > PS2: does it makes sense to patch kubespray to skip selinux setup on oracle linux 8 hosts? I would lean towards no, but...

I think we should just remove the samples inventories (or at least the variables) and rely on roles defaults (also for documentation). For some data point, when I came to...