Henri Schubin

Results 99 comments of Henri Schubin

Yes. Only changes would only be applied as they happen, not retroactively (via timer, resync command, joining or linking)

That is not what that option does, ```yaml # DiscordChatChannelBlockBots: whether bots should be blocked from Discord -> MC chat ``` But DiscordSRV shouldn't trigger canned responses for bots at...

> Is this related to an error that I'm experiencing during startup/reloads: > > ``` > [ERROR]: [DiscordSRV] java.lang.NoSuchFieldException: modifiers > [ERROR]: [DiscordSRV] at java.base/java.lang.Class.getDeclaredField(Class.java:2782) > [ERROR]: [DiscordSRV] at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.getDeclaredField(AbstractDefaultRulesReflectionProxy.java:90)...

PlaceholderAPI placeholders are only replaced when players are online. Support for offline placeholder support/not syncing while offline could be added. Changing to enhancement instead of bug

https://github.com/DiscordSRV/Ascension/blob/3bff3610c905ded29f394ac7af9aaa3140181bc9/common/src/main/java/com/discordsrv/common/feature/bansync/BanSyncModule.java#L190 https://github.com/DiscordSRV/Ascension/blob/3bff3610c905ded29f394ac7af9aaa3140181bc9/common/src/main/java/com/discordsrv/common/feature/bansync/BanSyncModule.java#L391 It's used in two different places, with two entirely different sets of contexts

Any specific reason to why you're running 1.21.1 instead of 1.21.4?

I'm open to supporting multiple versions within reason (versions that are actually being used). But the main problem is probably going to be the dependency on [adventure-platform](https://github.com/KyoriPowered/adventure-platform-mod) which only targets...

Staff++ changes the gamerule to "hide advancements", https://github.com/garagepoort/StaffPlusPlus/blob/f1358596e9f3837d82da87ced3e33aceedbd4e1c/src/main/java/net/shortninja/staffplus/core/domain/staff/mode/listeners/ModeAdvancementListener.java#L34-L44 Doesn't currently work as DiscordSRV checks the gamerule off thread, https://github.com/DiscordSRV/DiscordSRV/blob/42aad8401b73c52bb4edd11d9a73aa8a6e1619c1/src/main/java/github/scarsz/discordsrv/listeners/PlayerAdvancementDoneListener.java#L86-L93

> Are we hiding the advancements wrong on our side, or is this an issue with DiscordSRV? It isn't necessarily wrong, but that code also has the side effect of...