vanilla-installer icon indicating copy to clipboard operation
vanilla-installer copied to clipboard

Change some value to fix installer failing for some people (free space error with extents stuff)

Open fluoriteByte opened this issue 1 year ago • 4 comments

a very simple value change that fixed two people on the discord's free space errors when installing into an SSD, solution discovered by coarel on discord, props to her untested on my system but they both had their errors fixed

fluoriteByte avatar Aug 19 '24 11:08 fluoriteByte

potentially fixes https://github.com/Vanilla-OS/vanilla-installer/issues/439 also i just remembered how to name the commits ima change it

fluoriteByte avatar Aug 19 '24 11:08 fluoriteByte

hi, coarel here, this probably shouldn't be merged because its a very janky fix but at least we know where the issue is. i don't have time to look into it today but maybe a better fix would be double checking the amount of space left on the drive after the operation to make sure it's the correct amount?

Coare1 avatar Aug 19 '24 13:08 Coare1

that wouldn't fix anything, the installation will still fail because of insufficient space, just that it's not lvm failing but albius. fluoritebytes solution completely gets rid of the error

axtloss avatar Aug 19 '24 13:08 axtloss

true, i guess we can't exactly check if theres enough space now that i'm looking at the code, that would have to be hardcoded into albius. is there not an issue with making the volumes not take up the full amount of space within the partition? that's the main thing i'm concerned about.

Coare1 avatar Aug 19 '24 13:08 Coare1

Superseded by #438

taukakao avatar Nov 20 '24 21:11 taukakao