vanilla-installer
vanilla-installer copied to clipboard
Vanilla-OS
feat:[close #349] Feature Request: Let choose multiple keyboard layouts
The title's been changed to closed but the PRs not been merged.
"close" here just means that merging this will close #349 Usually, we would use "fix" here but it's not a bug so "close" is more appropriate
Something's weird with the checkboxes. Apparently it only updates the selected layouts if I press the row itself.
My guess is that the checkbox toggle signal needs to connect to the same function as the row.
Screencast from 2024-06-17 14-43-10.webm
The proper signal should be toggled https://docs.gtk.org/gtk3/class.CheckButton.html
Selecting the already existing layout would be confusing since you can select multiple keyboard layouts so you wouldn't know English US is already selected. So should we stop automatically selecting the existing layout?
I would remove the default. Ofc, the "next" button should be disabled if nothing is selected
It's weird no one pointed out it failed in the finals, but it's fixed now.
I was testing and my eyes fell on the test field below. It is not clear to me what I am testing, which of the 2 layouts I have chosen (en/it)
The one you choose first becomes your default keyboard, and in Gnome you can choose between them with a dialog in the top right. Does the reduced session have the choosing dialog?
Ah you are right, yeah probably not so easy to understand but I think it is fine for now. Anyway can you squash into a single commit?