vaken
vaken copied to clipboard
Add Docker and Docker Compose
Code Climate has analyzed commit 06c34ce5 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (0% is the threshold).
This pull request will bring the total coverage in the repository to 45.0% (0.0% change).
View more on Code Climate.
This also looks good to me–I'm going to play around with the Docker build a bit more later today.
This also looks good to me–I'm going to play around with the Docker build a bit more later today.
I think we also should add mongodb service here so we have db locally instead of writing to atlas, but not sure how useful would it be
This also looks good to me–I'm going to play around with the Docker build a bit more later today.
I think we also should add mongodb service here so we have db locally instead of writing to atlas, but not sure how useful would it be
I think we can make a separate issue for that, and go ahead and merge this in, then, if you're fine with that. Also, this is related to the GCP env var bug, since docker-compose was throwing an error for how I was setting up my gcp environment variables.
@semenodp not sure if you're still interested in working on this, but I think that having mongo locally would be a huge boon for contributors. Would you be interested in setting that up?
@semenodp not sure if you're still interested in working on this, but I think that having mongo locally would be a huge boon for contributors. Would you be interested in setting that up?
@leonm1 that should not take long to set up. When would you like for this to be done?
At your leisure. I'm working through all the PRs to try and clean up this project and do some polish work. Thanks for offering!
/rebase
@leonm1 I added mongodb to run in dev environment with docker-compose. Hardcoded the env variable just for sanity. Feel free to review and try locally.