darkmatter-grub2-theme icon indicating copy to clipboard operation
darkmatter-grub2-theme copied to clipboard

Incorrect path in grub with python install method (Pling package)

Open ninjaki8 opened this issue 1 year ago • 3 comments

Hi,

I just wanted to share a small issue I encountered while installing the darkmatter theme. After extracting arch-2K.zip and running:

sudo python3 darkmatter-theme.py -i

I noticed that the script generated an incorrect path entry in GRUB:

GRUB_THEME="/boot/grub/themes//darkmattertheme.txt"

I manually fixed it on my end, but I figured you might want to be aware of it.

Thank you for your work on this -- it's much appreciated! 😊

ninjaki8 avatar Feb 15 '25 17:02 ninjaki8

Problem is here ->

  1. Download zip file from https://www.pling.com/p/1603282/ (does not matter which one, version 2.3)
  2. On line 118 THEME_DIR = f"{GRUB_THEMES_DIR}/{THEME}" in darkmatter-theme.py
  3. it join GRUB_THEMES_DIR = "/boot/grub/themes/" and THEME = "darkmatter"
  4. result is /boot/grub/themes//darkmattertheme.txt

Please update your python script inside all archives on pling website.

atr0p1ne avatar Feb 18 '25 00:02 atr0p1ne

also this one is wrong THEME_PATH = f"{THEME_DIR}theme.txt"

i think it will be fixed when you move slash to the right like this THEME_DIR = f"{GRUB_THEMES_DIR}{THEME}/"

atr0p1ne avatar Feb 18 '25 00:02 atr0p1ne

@atr0p1ne @ninjaki8 Thanks for letting me know, I am aware of that issue actually. To fix it, I’ll need to repackage all the themes and reupload everything. I’ll try to get it done as soon as possible, as time allows :) By then, you guys can use the Github version, it should work fine, I’ve also pinned this issue for any new users

VandalByte avatar Feb 24 '25 14:02 VandalByte