wine icon indicating copy to clipboard operation
wine copied to clipboard

f4sefix from @hdmap

Open ghost opened this issue 7 years ago • 6 comments

This fixes https://github.com/ValveSoftware/Proton/issues/170

ghost avatar Aug 23 '18 09:08 ghost

Somewhat disappointed this hasn't been applied yet after almost 2 months; I wonder why.

Rabcor avatar Oct 14 '18 11:10 Rabcor

maybe because the patches could introduce other problems but i think its worth putting it in a beta and keeping an eye on it.

cjwijtmans avatar Oct 14 '18 15:10 cjwijtmans

Well, there's no reason to think it will break anything else, but there's also no reason thinking it wouldn't. For all we know it might fix a bunch of other things unexpectedly with no downsides, who knows how many games would benefit from being able to do, well, these things https://github.com/hdmap/wine-hackery/tree/master/f4se . It's exactly why we have a beta right?

Personally I have a suspicion that anything negatively affected would be legacy software from the pre-XP era of windows.

I wonder though, if there's a possibility they could make it possible to create unique wine environments with these kinds of fixes only applied on a per-game basis, so that if oblivion/skyrim/skyrimse/fallout3/falloutnv/fallout4 are installed, it would use one patched version of wine but use an unpatched version for other ones? I suppose the tricky part might be doing it without using too much space as those sorts of things might add up a bit eventually.

In this case for example, all it would probably require is a patched ntdll.dll; it shouldn't be that hard to store this patched ntdll.dll somewhere in proton and use it only in prefixes for games that need it.

Rabcor avatar Oct 15 '18 10:10 Rabcor

Hi! This may sound stupid, but I couldn't find anywhere where your patch "Patch of Exile partial fix" would help this issue. Is this patch intended, or an accidental addition?

ghost avatar Oct 19 '18 11:10 ghost

Sorry for the noise here, I changed the commit message by @zfigura to reference the correct repo now.

kakra avatar Jan 05 '19 00:01 kakra

The get_free_mem_state_callback patch is merged into Wine as of 4.5 and the other patch is only required for older versions of f4se/skse64. After Protons Wine is synced to mainline Wine again this should be fixed.

hdmap avatar Jun 11 '19 22:06 hdmap