steam-for-linux icon indicating copy to clipboard operation
steam-for-linux copied to clipboard

Non-steam-game does not cleanly quit.

Open trigg opened this issue 3 years ago • 23 comments

Your system information

  • Steam client version (build number or date): 1646795571 Wed Mar 9 2:07 AM UTC

  • Distribution (e.g. Ubuntu): SteamOS 3

  • Opted into Steam client beta?: [Yes/No] Yes

  • Have you checked for system updates?: [Yes/No] Yes

Please describe your issue in as much detail as possible:

Running two different non-steam-games and closing one (either with "Exit Game" option or any in-game/in-app quit prompt) will cause it to return to a spinning steam logo. The non-steam-game will remain in the list of running game in the 'Steam' menu and in library will have the option 'Resume' not 'Play' on the play button. Pressing 'Resume' returns the user to the spinning waiting screen.

The Steam client needs to be restarted to return the 'Play' option

Steps for reproducing this issue:

  1. Add two different non-steam-games
  2. Run one, press 'Steam' and go to Library and run another non-steam-game
  3. Press quit in the game menu or 'Exit game' from the 'Steam' menu
  4. press 'Steam' and go to library and try to run the stopped game again

Other

For clarity this is an issue in the latest Deck beta. Uncertain if it is important but the reaper process for the app that is closed goes 'defunct' at the point this is triggered. I've tested this with a handful of different games, utilities etc with no variation.

trigg avatar Mar 11 '22 16:03 trigg

If it matters, I'm also experiencing this issue while on the beta version of SteamOS 3. For example, I have appimages of Discord and Telegram. Opening both is fine, and so is closing 1 of them. When you try to close the other one though, it'll hang forever and can't be reopened from Steam until you exit to desktop mode and then reload game mode.

Riku5543 avatar Mar 16 '22 18:03 Riku5543

Can reproduce in latest stable also

ANBAL534 avatar May 18 '22 07:05 ANBAL534

Seeing this on Steam Deck. Killing or kill-9-ing the app also does nothing. The process will disappear but the app in the UI remains and can't be used / relaunched untill the client is restarted. Have seen the same issue with flatpak and appimage apps.

safijari avatar May 30 '22 20:05 safijari

This happens the same with 'native' installed apps. Add non-steam firefox & pavucontrol, launch both in game mode & try to quit one, both show a grayed out 'Exiting game...' and neither quit, or can be closed.

If you then close the last tab on firefox you get a spinning steam logo but it remains in the list of open apps on the Steam menu and is not able to be closed or launched again

trigg avatar May 31 '22 11:05 trigg

Seeing this on latest beta too. Makes multitasking almost completely useless.

AAGaming00 avatar Jun 18 '22 17:06 AAGaming00

Encountered this issue the other day while trying to get lutris and protonup-qt to working as complimentary software. Really hoping we get a response soon.

TrainDoctor avatar Jun 20 '22 15:06 TrainDoctor

Also been experiencing this issue on the Deck. Would really love a solution to this! Not having to restart Steam every time I want to close an app would be amazing.

Ginjutsu avatar Jul 07 '22 17:07 Ginjutsu

Also still experiencing this issue in the latest preview build. While running an Emulator and Chrome in game mode then trying to close Chrome it locks the system up. Chrome gets stuck in a "closing app" loop, reboot seems to be the only way to resolve. Not specific to Chrome, whatever app is closed seems to get stuck in this manner

Drakje avatar Aug 07 '22 13:08 Drakje

Yep iv also noticed this. Was running discord in gaming mode & running an emulator & hitting quit game made both try to quit but instead the Deck just gets stuck in a infinite loop! Needs a fix!

Richi08 avatar Aug 17 '22 00:08 Richi08

Seems like closing from within apps works fairly consistently, but killing it from outside of it (whether by the Steam menu or via System Monitor) seems to cause the hanging issue.

stansz avatar Aug 26 '22 04:08 stansz

Seems like closing from within apps works fairly consistently, but killing it from outside of it (whether by the Steam menu or via System Monitor) seems to cause the hanging issue.

I have to disagree with this having just tested it again. Opened 2 non-steam games, and closed one using an in-app exit choice has caused the hang. Both as the most-recent and least-recent run non-steam game.

trigg avatar Aug 26 '22 08:08 trigg

Got the same problem with Guildwars 2 + Firefox + Discord Can't close any of them. Only hard reboot/poweroff works.

cimba007 avatar Sep 04 '22 12:09 cimba007

Observations with Two Non-Steam Games via the Steam Console (on Windows 11, but it could help explain people's Non-Steam games failing to close issues on the Steam Deck)

apps_running after first game launch:

 - AppID 0, GameID 17989158382581317632, ProcessID 10556, IP:Port 0.0.0.0:0 
   commandline ""C:\Program Files\Audacity\Audacity.exe"" 
   extra info "Audacity"  
   associated PIDs (  10556, )  
   dwLastIsRunningCheck 1355434 

apps_running after second game launch:

 - AppID 0, GameID 18082849065464233984, ProcessID 8024, IP:Port 0.0.0.0:0 
   commandline ""D:/Portable Programs/Game Stuff/GlosSI-0.0.7.0/GlosSITarget.exe" Notepad.json" 
   extra info "Notepad"  
   associated PIDs (  10556,8024, )  
   dwLastIsRunningCheck 1389797 

Game ID is correct, however, it would appear the games get merged due to the AppID being the same (theoretically)

CarJem avatar Sep 09 '22 16:09 CarJem

Is there any way to force the AppID to be something different to test? I know you can using an environment variable, if that works generally it might be a temporary workaround to set the AppID to some random value (maybe the process' PID?) + some extra digits to make sure it doesn't clash with any existing AppIDs

GorrillaRibs avatar Sep 09 '22 19:09 GorrillaRibs

Seems to be working much better now (I am on beta channel). Majority of non steam apps close for me now (haven't had the stuck app for a while now)

EDIT: nevermind, issues still exists when having multiple apps open

stansz avatar Sep 10 '22 01:09 stansz

@stansz what did you do exactly?

cimba007 avatar Sep 10 '22 06:09 cimba007

Beta channel

stansz avatar Sep 10 '22 15:09 stansz

I'm on the beta channel on my Steam Deck and still having the same issue in game mode (having multiple apps open results in a permanent exiting screen until restarting Steam/rebooting) - @stansz are you on a desktop/using desktop mode on a deck?

GorrillaRibs avatar Sep 10 '22 15:09 GorrillaRibs

I am on Preview and nothing changed. Example is GW2 (non steam) + Firefox or Discord

cimba007 avatar Sep 10 '22 16:09 cimba007

Is there any way to force the AppID to be something different to test? I know you can using an environment variable, if that works generally it might be a temporary workaround to set the AppID to some random value (maybe the process' PID?) + some extra digits to make sure it doesn't clash with any existing AppIDs

I've tried many works around for this, but none of them would be as good as Valve actually fixing the issue. Sadly it looks like unless we starting being more clear about what the issue actually is... it might be a bit....

CarJem avatar Sep 10 '22 20:09 CarJem

Sorry guys, was super busy and didnt' have my deck with me the past week or so.

Did some further testing and can confirm issue still exists when multitasking/having more apps open and then trying to close out.

Having single apps open, and then closing seems to work for me, but as soon as I open another app, it hangs on closing (example I tested was RetroArch + Chrome, as well as Spotify + VLC + Chrome ... all hung when they were open at same time, but when open individually, I seemed to be able to close out without issues).

stansz avatar Sep 11 '22 19:09 stansz

Sorry guys, was super busy and didnt' have my deck with me the past week or so.

Did some further testing and can confirm issue still exists when multitasking/having more apps open and then trying to close out.

Having single apps open, and then closing seems to work for me, but as soon as I open another app, it hangs on closing (example I tested was RetroArch + Chrome, as well as Spotify + VLC + Chrome ... all hung when they were open at same time, but when open individually, I seemed to be able to close out without issues).

This is in line with my observations as well...

and fits in really nicely with the technical explanation for why this happens!

https://github.com/ValveSoftware/steam-for-linux/issues/8474#issuecomment-1242212810

I think we have a suitable explanation for Valve for why this happens now!

CarJem avatar Sep 12 '22 13:09 CarJem

Replying to https://github.com/ValveSoftware/steam-for-linux/issues/8474#issuecomment-1243728613

Same for me, individual apps close without problem

mrshroomy avatar Sep 12 '22 14:09 mrshroomy

The same for me, on stable and beta channel.

mrs-th avatar Sep 24 '22 08:09 mrs-th

I'm also having issues with this, this is definitely a flatpack issue. It seems like the steamOS gaming mode tries to terminate all flatpack instances when exiting from the menu. There must be a way, or some kind of flag for steamOS to identify each process or instance. I'll take a look at it further tomorrow and report back.

on the stable channel.

jasonh9 avatar Sep 28 '22 04:09 jasonh9

I'm also having issues with this, this is definitely a flatpack issue. It seems like the steamOS gaming mode tries to terminate all flatpack instances when exiting from the menu. There must be a way, or some kind of flag for steamOS to identify each process or instance. I'll take a look at it further tomorrow and report back.

on the stable channel.

if this was a flatpak issue... then wouldn't this be a non-issue on Windows as well... where the same issue is happening there too?

CarJem avatar Sep 28 '22 13:09 CarJem

I'm also having issues with this, this is definitely a flatpack issue. It seems like the steamOS gaming mode tries to terminate all flatpack instances when exiting from the menu. There must be a way, or some kind of flag for steamOS to identify each process or instance. I'll take a look at it further tomorrow and report back. on the stable channel.

if this was a flatpak issue... then wouldn't this be a non-issue on Windows as well... where the same issue is happening there too?

you're right, it's not exclusively a flatpak issue after looking into it more. definitely not so definitely.

jasonh9 avatar Sep 28 '22 23:09 jasonh9

Here is a dump of my content_log.txt within /home/deck/.local/share/Steam/logs

it seems like that the steam client is loosing track of the PIDs or the mapping between the gameID and PID is erroneous.

2022-09-28 18:35:07] Game 16344590979463905280 adding PID 64508 as a tracked process "/home/deck/.local/share/Steam/ubuntu12_32/reaper SteamLaunch AppId=2630048210 -- /home/deck/.local/share/Steam/ubuntu12_32/steam-launch-wrapper -- "/usr/bin/flatpak" run --branch=stable --verbose --arch=x86_64 --command=/app/bin/chrome --file-forwarding com.google.Chrome @@u @@ --window-size=1024,640 --force-device-scale-factor=1.25 --device-scale-factor=1.25" [2022-09-28 18:35:07] Game 16344590979463905280 adding PID 64509 as a tracked process [2022-09-28 18:35:07] Game 16344590979463905280 adding PID 64521 as a tracked process [2022-09-28 18:35:25] Game 16344590979463905280 no longer tracking PID 64521, exit code -1 [2022-09-28 18:35:25] Game 16344590979463905280 no longer tracking PID 64509, exit code -1 [2022-09-28 18:35:25] Game 16344590979463905280 no longer tracking PID 64508, exit code 0 [2022-09-28 18:35:52] Game 16344590979463905280 adding PID 64937 as a tracked process "/home/deck/.local/share/Steam/ubuntu12_32/reaper SteamLaunch AppId=2630048210 -- /home/deck/.local/share/Steam/ubuntu12_32/steam-launch-wrapper -- "/usr/bin/flatpak" run --branch=stable --verbose --arch=x86_64 --command=/app/bin/chrome --file-forwarding com.google.Chrome @@u @@ --window-size=1024,640 --force-device-scale-factor=1.25 --device-scale-factor=1.25" [2022-09-28 18:35:53] Game 16344590979463905280 adding PID 64938 as a tracked process [2022-09-28 18:35:53] Game 16344590979463905280 adding PID 64945 as a tracked process [2022-09-28 18:36:02] Game 16344590979463905280 no longer tracking PID 64945, exit code -1 [2022-09-28 18:36:02] Game 16344590979463905280 no longer tracking PID 64938, exit code -1 [2022-09-28 18:36:02] Game 16344590979463905280 no longer tracking PID 64937, exit code 0 [2022-09-28 18:36:07] Game 16344590979463905280 adding PID 65329 as a tracked process "/home/deck/.local/share/Steam/ubuntu12_32/reaper SteamLaunch AppId=2630048210 -- /home/deck/.local/share/Steam/ubuntu12_32/steam-launch-wrapper -- "/usr/bin/flatpak" run --branch=stable --verbose --arch=x86_64 --command=/app/bin/chrome --file-forwarding com.google.Chrome @@u @@ --window-size=1024,640 --force-device-scale-factor=1.25 --device-scale-factor=1.25" [2022-09-28 18:36:07] Game 16344590979463905280 adding PID 65330 as a tracked process [2022-09-28 18:36:07] Game 16344590979463905280 adding PID 65335 as a tracked process [2022-09-28 18:36:19] Game 17224870614410461184 adding PID 65733 as a tracked process "/home/deck/.local/share/Steam/ubuntu12_32/reaper SteamLaunch AppId=3242867109 -- /home/deck/.local/share/Steam/ubuntu12_32/steam-launch-wrapper -- "konsole" --fullscreen" [2022-09-28 18:36:19] Game 17224870614410461184 adding PID 65734 as a tracked process [2022-09-28 18:36:19] Game 17224870614410461184 adding PID 65755 as a tracked process [2022-09-28 18:36:19] Game 17224870614410461184 adding PID 65757 as a tracked process [2022-09-28 18:36:19] Game 17224870614410461184 adding PID 65758 as a tracked process [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65758, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65757, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65755, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65734, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65733, exit code 0 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65335, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65330, exit code -1 [2022-09-28 18:37:45] Game 17224870614410461184 no longer tracking PID 65329, exit code 0

jasonh9 avatar Sep 29 '22 01:09 jasonh9

confirmed that this issue hasn't been fixed as of 3.3.2

jasonh9 avatar Oct 06 '22 21:10 jasonh9

It indeed seems to be very random, if there is any way I can help out I'd glady do so.

Edit: could it perhaps be that the game that I start, spawns another pid and steamos lost track in this case?

Thijmen avatar Oct 12 '22 12:10 Thijmen