steam-audio icon indicating copy to clipboard operation
steam-audio copied to clipboard

[UE] OpenCL devices are never utilized

Open Oldnice opened this issue 1 year ago • 2 comments

A logical error in SteamAudioManager.cpp prevents OpenCL devices from ever being utilized:

IPLerror Status = iplOpenCLDeviceListCreate(Context, &OpenCLDeviceSettings, &OpenCLDeviceList);
if (Status != IPL_STATUS_SUCCESS)
{
	...
	iplOpenCLDeviceListCreate(Context, &OpenCLDeviceSettings, &OpenCLDeviceList);
	...
}
else
{
	UE_LOG(LogSteamAudio, Warning, TEXT("Unable to create OpenCL device list. [%d]"), Status);
}

Intention was probably to have the status check in reverse:

IPLerror Status = iplOpenCLDeviceListCreate(Context, &OpenCLDeviceSettings, &OpenCLDeviceList);
if (Status == IPL_STATUS_SUCCESS)
{
	...
	iplOpenCLDeviceListCreate(Context, &OpenCLDeviceSettings, &OpenCLDeviceList);
	...
}
else
{
	UE_LOG(LogSteamAudio, Warning, TEXT("Unable to create OpenCL device list. [%d]"), Status);
}

Oldnice avatar Dec 07 '23 15:12 Oldnice

That is also the reason, why Radeon Rays doesn't work. Mine is working now thanks to your investigation. :) But when Radeon Rays enabled, reflections sound stutters a lot.

sociofall avatar Mar 01 '24 20:03 sociofall

Can confirm, just tested it and for the first time since UE plugin release, OpenCL devices do initialize.

SkacikPL avatar Mar 03 '24 12:03 SkacikPL