ValveSoftware
[TF2] Add Pyro kill animations
Description
Video demonstration: https://youtu.be/uVbb11_q6kw
This PR enables the unused burning death animations found in every class except the Pyro. The process for doing so has been adjusted to work like other custom death animations, only being activated by specific fire based kills (TF_DMG_CUSTOM_BURNING, TF_DMG_CUSTOM_BURNING_ARROW, TF_DMG_CUSTOM_BURNING_FLARE, TF_DMG_CUSTOM_FLARE_PELLET, TF_DMG_CUSTOM_PLASMA_CHARGED) rather than players simply being on fire at the time of death.
It also modifies C_TFRagdoll::FrameAdvance to add the "turn to ash" particle effect at the end of the animation sequence to clean up the corpse in an appropriate way.
~~I know this is probably not going to get accepted, I like them and I wanted to at least try to get them back in~~
I suspect these were intentionally scrapped because they can be mistaken for alive players taunting (I believe TF2C had this problem in playtests and then disabled it by default)
Community contributions should purely be bug fixes/security fixes and nothing else. Easily a thumbs down.
I suspect these were intentionally scrapped because they can be mistaken for alive players taunting (I believe TF2C had this problem in playtests and then disabled it by default)
Potentially, I've had a plugin on my server that utilizes them and most people don't even seem to notice them at all, so I figured why not try and see, plus it was fun
Making this a server-config item that admins could manage, you'd get the best of both worlds.
Making this a server-config item that admins could manage, you'd get the best of both worlds.
Better yet, I've added a client side cvar!
I suspect these were intentionally scrapped because they can be mistaken for alive players taunting (I believe TF2C had this problem in playtests and then disabled it by default)
I don't see how animations can confuse players. There's backstab animations. Just shoot them to make sure they are actually dead.
Making this a server-config item that admins could manage, you'd get the best of both worlds.
Better yet, I've added a client side cvar!
There you go, best of both worlds.
I know this is probably not going to get accepted, I like them and I wanted to at least try to get them back in
Useful for community forks
I suspect these were intentionally scrapped because they can be mistaken for alive players taunting (I believe TF2C had this problem in playtests and then disabled it by default)
I don't see how animations can confuse players. There's backstab animations. Just shoot them to make sure they are actually dead.
The problem is that spy can only stab so many people at once, while pyro can burn a whole group of people and even kill at once. Creating a cluster of dead players doing animations. The backstab animations are really short and are a good indicator of "Hey a spy just stabbed that sniper, theres a spy around here". These burned ones are inconsistent in both their length and quality, some of them are long and others short. They're missing face flexes, Heavy shows a perfect example of this with him looking up with a blank face when he supposedly should be screaming. They don't really indicate anything either, they just show "Hey theres a pyro" which you should already know from seeing people on fire.
However if this was to ever be added, having a cvar toggle or even toggle in the settings menu itself would be ideal. As a PR that forks/mods can use, that's perfectly fine for those creators to use it for their needs.
Made a version of this with the ability to disable the ash effect for community mods
https://github.com/BitlDevelopmentStudios/source-sdk-2013-bds-base/commit/b03b90bae80c1dcf45ea226c21b53f863504da06
Community contributions should purely be bug fixes/security fixes and nothing else. Easily a thumbs down.
While I see your point, I believe that the mindset of "community should only fix" is pretty bad.
I agree that this PR isn't something that should be added, but not all additions are equal. For example someone might want to add a toggle for a thing that bothers people (no example in mind, so just imagine), would that be bad?
I believe that additions should be limited to Quality of Life features rather than none at all, although I wouls bet in the future we may even see exceptions to this. At the end of the day it is really just not up to us to decide whether things like this should be merged. (At least I doubt we have a big enough say)
at the end of the day it's up to valve whether or not to merge something like this, if e.g. people here like the idea enough then it probably gives them reason enough to consider pushing this in whatever next update they have in store, and if it doesnt make it in, other mods can benefit from these changes
I had always had the assuption that theses animations where meant for flare crits only?
Also, a death animation by burning exists for the Pyro, it just wasn't ever included into the game's files. If theses shall ever be introduced it's all up to Valve.
