source-sdk-2013 icon indicating copy to clipboard operation
source-sdk-2013 copied to clipboard

Fix the caber being excluded from achievements, and fix intended extended melee hits

Open Reabstraction opened this issue 10 months ago • 2 comments

In TF2, the game expects us to be charging whilst attacking to get a range bonus from 48 (Bottle)/72 (Sword) to 128 Unfortunately, this is bugged You see, melee hits aren't instant But your charge ends the instant you try to swing As such, we can never use the extended range, since we aren't "charging" when the hit connects This can be worked around by swinging as soon as we charge, but this means giving up a crit and requiring us to be very close

This pull request fixes this, by introducing a class variable called m_bWasCharging, which is set if you swing whilst charging, and unset when the hit is done or you swap weapons

I also fixed the caber being excluded from a few achievements

Finally; the caber can now deal minicrits from shields

Reabstraction avatar Feb 20 '25 15:02 Reabstraction

LMK if a CLA needs to be signed, or if there are any issues with the pull request

Reabstraction avatar Feb 20 '25 15:02 Reabstraction

imo i would interpret this as also a balance change instead of as only a bug fix

wgetJane avatar Feb 25 '25 23:02 wgetJane

@Reabstraction personally i feel like this should be 3 different prs:

  • caber achievements fix
  • caber mini-crits (seems like a balance change?)
  • extended charge melee range (bug fix but also seems like a balance change?)

wgetJane avatar Feb 28 '25 06:02 wgetJane