[TF2] fix: cheat-protect commands which control panel visibility
some VGUI exploits to gain information which you normally cannot see (explained outside of commit)
ValveSoftware/Source-1-Games#2488
should also be done for vgui_togglepanel: https://github.com/mastercomfig/tf2-patches-old/commit/a02595b7aa1bb909e0734a37358863c145c99470
I assume you tested this in TC2, but this isn't gonna break VGUI right? Like it's not using this codepath normally?
I don't agree with this because the panels that are shown and hidden themselves should be fixed IMO, if any other way to show and hide panels gets discovered, those panels will still give an advantage. Patching the panels themselves directly to check for permission of the information on them would be a lot stronger of protection against this. This tech is also used in huds to add custom menus. So this patch would break some huds. VillageGreenPreserver/hudmenu-base
Yeah that's fair. If a dev comes around and fixes specgui, please do get in contact with me or ETF2L AntiCheat staff, there is one more case that's exploitable and I'd rather not make it public for the time being. Thanks!
I assume you tested this in TC2, but this isn't gonna break VGUI right? Like it's not using this codepath normally?
Yes, some custom HUDs do rely on this functionality to create custom menus, but the main game had no issues with this patch.