source-sdk-2013 icon indicating copy to clipboard operation
source-sdk-2013 copied to clipboard

[TF2] fix: cheat-protect commands which control panel visibility

Open mastercoms opened this issue 10 months ago • 3 comments

some VGUI exploits to gain information which you normally cannot see (explained outside of commit)

ValveSoftware/Source-1-Games#2488

should also be done for vgui_togglepanel: https://github.com/mastercomfig/tf2-patches-old/commit/a02595b7aa1bb909e0734a37358863c145c99470

mastercoms avatar Feb 19 '25 10:02 mastercoms

I assume you tested this in TC2, but this isn't gonna break VGUI right? Like it's not using this codepath normally?

ldesgoui avatar Feb 19 '25 12:02 ldesgoui

I don't agree with this because the panels that are shown and hidden themselves should be fixed IMO, if any other way to show and hide panels gets discovered, those panels will still give an advantage. Patching the panels themselves directly to check for permission of the information on them would be a lot stronger of protection against this. This tech is also used in huds to add custom menus. So this patch would break some huds. VillageGreenPreserver/hudmenu-base

Niterux avatar Feb 19 '25 13:02 Niterux

Yeah that's fair. If a dev comes around and fixes specgui, please do get in contact with me or ETF2L AntiCheat staff, there is one more case that's exploitable and I'd rather not make it public for the time being. Thanks!

ldesgoui avatar Feb 23 '25 12:02 ldesgoui

I assume you tested this in TC2, but this isn't gonna break VGUI right? Like it's not using this codepath normally?

Yes, some custom HUDs do rely on this functionality to create custom menus, but the main game had no issues with this patch.

mastercoms avatar Jul 27 '25 14:07 mastercoms