source-sdk-2013 icon indicating copy to clipboard operation
source-sdk-2013 copied to clipboard

vbsp issue: Empty worldspawn when using a map manifest.

Open maxdup opened this issue 9 years ago • 3 comments

Vbsp makes an empty worldspawn when fed with a vmm file. The resulting worldspawn has none of the essential values you would expect from a worldspawn such as "skyname" or "detailvbsp".

I'm not fluent in c++, but I think the problem is around src/utils/vbsp/manifest.cpp, line 301. An empty worldspawn is created but nothing is done to it as far as I can tell. values should probably be taken from the primary or toplevel map.

(the tf2 toolset would benefit from fixing this)

maxdup avatar Jul 16 '15 20:07 maxdup

cool... , have u tried to vbsp .cpp ?

bmk10 avatar May 22 '16 09:05 bmk10

This seems to fix the problem: https://github.com/DeathByNukes/source-sdk-2013/commit/2f915b95a37be42231fef3a0502ea73c045f1656 I've only tested this in one Source game though.

DeathByNukes avatar Aug 22 '18 03:08 DeathByNukes

@DeathByNukes Nice! this should do it. I'll test that out when I find the time

maxdup avatar Aug 25 '18 22:08 maxdup