source-sdk-2013 icon indicating copy to clipboard operation
source-sdk-2013 copied to clipboard

[TF2] fix: remove early return in coach request check

Open CosminPerRam opened this issue 7 months ago • 2 comments

Description

Early returning false skips the threshold of hours check and because of the previous checks, makes the function always return false unconditionally.

CosminPerRam avatar May 27 '25 22:05 CosminPerRam

It's probably added to intentionally disable coaching.

HyperionCoding avatar May 28 '25 12:05 HyperionCoding

Possible indeed, an official clarification if this is intentional would be nice to have to add a documentation comment instead (and to move the early return at the beginning to skip redundant checks).

CosminPerRam avatar May 28 '25 12:05 CosminPerRam