openvr icon indicating copy to clipboard operation
openvr copied to clipboard

[BUG]: `openvr_driver.h` does not comply with Werror and pedantic

Open okawo80085 opened this issue 3 years ago • 1 comments

When building a driver with -Wall -Wextra -pedantic -Werror enabled, openvr_driver.h breaks

If the driver developer wants to enforce Werror in their driver they will not be able to do so because vr::IVRDriverDirectModeComponent has empty methods defined, instead of having pure virtual methods like literally every other component interface in openvr_driver.h And on line 3659 there is an excessive semicolon

Why does vr::IVRDriverDirectModeComponent need to have empty default methods when literally every other interface has purely virtual methods?

If there is a practical purpose for them in the API, why is it not documented?

okawo80085 avatar Sep 26 '21 16:09 okawo80085

I have to mention that this is the only what i caught with my driver, other parts of this API can be non compliant, like the application API...

okawo80085 avatar Sep 26 '21 17:09 okawo80085