halflife icon indicating copy to clipboard operation
halflife copied to clipboard

[CS 1.6] VGUI problems: broken links and symbols duplication

Open Belarusan opened this issue 2 years ago • 3 comments

When you start the map, in the initial window (before choosing a team) there is a link to the official website of the CS. If you click on it, it's just a gray window and the title "-113".

Next, when you choose a team, you can see the map description (each map has its own description). But the last few characters (~15) are duplicated. It's strange.

Is it an objective problem? Is there a way to fix it myself? Is it reasonable to expect that this problem will be officially fixed?

Version: Protocol version 48 Exe version 1.1.2.7/Stdio (cstrike) Exe build: 19:53:27 Aug 3 2020 (8684)

20230411120605_1 20230411120608_1 20230411120615_1 20230411120723_1 20230411120823_1

Belarusan avatar Apr 11 '23 10:04 Belarusan

The website link is http://www.counter-strike.net. It redirects to the https version. Looks like it fails to load due to error 113: ERR_SLL_VERSION_OR_CIPHER_MISMATCH.

GoldSource uses CEF1 to render HTML, it's an obsolete version of Chromium that went out of support a decade ago. It probably doesn't support newer encryption protocols so some sites will fail to load as a result. google.com does load for example.

The map briefing text issue is happening because the briefing text files use Windows style line endings (\r\n). The text panel seems to be counting the \r characters towards the total character count but it isn't rendering them. Curiously it isn't happening with the first few lines. de_dust's text has 16 lines of text (including the empty last line) but only draws 13 characters past the end of the actual text.

There's probably a bug in the GoldSource engine version of this method: https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/vgui2/vgui_controls/RichText.cpp#L714-L899

Or somewhere else in the RichText class.

It should be fairly easy to pinpoint the cause by stepping through the code with a debugger.

SamVanheer avatar Apr 11 '23 21:04 SamVanheer

Basically related to TLS 1.0 not being supported also on that website. The minimum I believe now is 1.8 and greater.

xLeviNx avatar Apr 18 '23 19:04 xLeviNx

OMG, the second issue (with duplication of symbols) has been fixed. I guess with the 25th anniversary update. Thanks.

This was done not in the code, but in the map description files — before was End of Line Sequence CRLF, but now it's just LF. Not sure what that means, but it fixed the problem completely.

The first issue with links and "-113" still remains, but I don't think it's a big problem.

Belarusan avatar Apr 26 '24 14:04 Belarusan