halflife icon indicating copy to clipboard operation
halflife copied to clipboard

Request: Port software water effect to OpenGL renderer.

Open JulianHeuser opened this issue 5 years ago • 10 comments

The water effect used in the software renderer looks arguably better than the OpenGL alternative (examples here: https://twitter.com/joewintergreen/status/1066947983730663424)

Of course it depends on how this effect is coded, and I'm aware that it might not be possible.

JulianHeuser avatar Apr 21 '19 02:04 JulianHeuser

Check out the latest BETA and this https://github.com/ValveSoftware/halflife/issues/1650

djdallmann avatar Apr 21 '19 04:04 djdallmann

I absolutely agree, and there are apparently explosion effects in the software renderer that aren't available in OpenGL too.

MFKitten avatar Apr 21 '19 08:04 MFKitten

@djdallmann did they do anything about the water ripple effect in the latest beta though?

MFKitten avatar Apr 21 '19 09:04 MFKitten

I checked, the beta fixes texture scaling but the water effects are the unchanged.

JulianHeuser avatar Apr 21 '19 13:04 JulianHeuser

The texture scaling was doable in a short amount of free time. The ripple effect needs some more hacks on the engine: either copy the software drawn ripple texture to hardware and render that or use pixel shaders (OpenGL 2.0).

mleise avatar Apr 21 '19 15:04 mleise

I second this big time, it would be amazing to see this, plus working gl_overbright, and so the original and faithful vision of the game would be preserved :) (except very minor details)

Deus-nsf avatar Oct 11 '19 13:10 Deus-nsf

Not sure if this is considered necrobumping this, but it would be nice to port that water effect over to OpenGL (as well as figure out how it's done).

DevelopmentDragon avatar Jun 18 '20 23:06 DevelopmentDragon

It's pretty easy to implement with just reuploading the texture https://github.com/FWGS/xash3d-fwgs/blob/master/ref/gl/gl_warp.c#L857-L1045 (see the end of file)

And performance drop seem to be negligible enough.

a1batross avatar Nov 19 '23 21:11 a1batross

I second this, the OpenGL water effect is inferior to software.

falojazz avatar Nov 24 '23 08:11 falojazz

I third this

captinwill avatar Jan 06 '24 02:01 captinwill