ValveSoftware
Merge forceRepaint fix into stable/3.7.x
Is there an existing issue for this?
- [x] I have searched the existing issues
Are you using any gamescope patches or a forked version of gamescope?
- [x] The issue occurs on upstream gamescope without any modifications
Current Behavior
My PR to fix a forceRepaint regression got merged a couple months back. So I assume it will go out with the next major release, but in the meantime anyone using my app on 3.7 still has a poor experience. The fix is one-line and was present in 3.6 until it was accidentally reverted in 3.7. Can it be merged into the next patch release of 3.7?
Steps To Reproduce
No response
Hardware information
- Distro:
- CPU:
- GPU:
- Driver Version:
Software information
- Desktop environment:
- Session type:
- Gamescope version:
- Gamescope launch command(s):
Which gamescope backends have the issue you are reporting?
- [ ] Wayland (default for nested gamescope)
- [ ] DRM (default for embedded gamescope, i.e. gamescope-session)
- [ ] SDL
- [ ] OpenVR
Logging, screenshots, or anything else
No response
Comparing: https://github.com/ValveSoftware/gamescope/blame/jupiter-3.6/src/steamcompmgr.cpp#L7971 https://github.com/ValveSoftware/gamescope/blame/jupiter-3.7/src/steamcompmgr.cpp#L8474 https://github.com/ValveSoftware/gamescope/blame/master/src/steamcompmgr.cpp#L8571 Indicates there was no cherrypick or backport that was later reverted, which makes this a straight request to cherry pick the commit to help undefined application mentioned at https://github.com/ValveSoftware/gamescope/commit/5f004e8e30b7e6fdf3a1378ebb1c2c429003b8da#commitcomment-162625873
It was added here and reverted in this commit. I'm not sure your concern about a cherry-pick?
Maybe you're pointing out that I used the word "revert" when it wasn't a literal git revert action? That's why I described it as "accidentally reverted," because it was an undo-ing of my change, accidentally, as part of another commmit.
Right, misread on my part from jumping back and forth with the line shifting. Carry on.