[portal] - crash bind something with impulse 101 make crash your game !

[kiddu25]

I make : bind I "impulse 101"

here a video show that : https://www.youtube.com/watch?v=Dc1nPalaT8s

[vrad-exe]

I think this is specifically related to the gravity gun, Portal Epic Edition is crashing when you pick it up now

[vrad-exe]

I decompiled client.dll and did a little digging into what's going on. The crash is related to the steam clips timeline markers feature. When you pick up a new weapon it adds a marker for that, and for the gravity gun specifically it checks if the gun is the "super" version from the Citadel, so that can be indicated in the recording.

To do this, the code casts a C_BaseCombatWeapon pointer to a C_BaseHLCombatWeapon pointer, but the gravity gun in Portal doesn't seem to extend from this class, so the cast fails and returns a null pointer. It then immediately tries to access this pointer (under the somewhat reasonable assumption that a weapon_physcannon entity would always extend from C_BaseHLCombatWeapon) and crashes with an access violation error.

Portal doesn't even have a functional super gravity gun (only the regular version works), and the clip markers feature is likely dependent on Steam-side configuration to work anyway. Unless both of those things are fixed, this check should probably just be disabled entirely for Portal so that the gravity gun works again.

[NathanL1370]

The commands give weapon_physcannon and impulse 101 work fine in this update and still give you the gravity gun as normal. However, picking up one directly still crashes the game.

Edit: The gravity gun pickup crash seems to be fixed.