Source-1-Games icon indicating copy to clipboard operation
Source-1-Games copied to clipboard

[TF2] Orphaned weapon unusual particles flooding screen (with repro info)

Open rabscootle opened this issue 3 years ago • 3 comments

REPRO INFO:

Repro video: https://www.youtube.com/watch?v=7x6cGcLR38c

  1. Load into a map with sv_cheats set to '1'
  2. Spawn in bot players ('tf_bot_add')
  3. Enable friendly fire (mp_friendly_fire '1')
  4. Die while holding out Unusual-quality weapon and spectate player in third-person view*
  5. Kill player you are spectating (i.e. 'bot_whack' command)
  6. Switch to first-person and then third-person (default key Spacebar) before Spectate switches to another player and/or player respawns
  • The spectator view does not necessarily change much aside from maybe requiring to press space bar one more time

All unusual weapon effects (Hot, Cool, Isotope, Energy Orb) currently have an issue where they can indefinitely flood a user's screen upon spawning in (and while spectating players). This particle stays on the user's screen until they switch to a weapon with the matching effect and swap off of it. Depending on the weapons a player owns/uses, this bug can occur enough times for it to be considered a disadvantage of owning Unusual-quality weapons.

IMG_5727 IMG_5726

rabscootle avatar Jun 22 '22 20:06 rabscootle

Was there ever a fix for this?

MostlyBags avatar Sep 10 '24 05:09 MostlyBags

I managed to put together a community fix for the orphaned weapon unusual particle issue. This fix currently applies to Energy Orb (due to it being the worst offender and the least amount of particle systems), but the same approach can be extended to other weapon unusuals once I have the time.

Here is the workshop link to the community fix (note: the community fix also includes custom particle systems for each warpaintable weapon so that the unusual effect can safely be reimplemented into the weapon unusual pool, but I split up the files so Valve can choose to ignore that): https://steamcommunity.com/sharedfiles/filedetails/?id=3561477398

How It's Done The fix is strictly particle system based and does not rely on code changes. Due to it just being a .pcf replacement, it should be quite simple to implement. In the .pcf, every particle system using "Constrain distance to path between two control points" was redone to avoid said constraint. I did this by adding a "Movement Lock to Control Point" operator with lock rotation enabled, and then added speed to "Position within Sphere" to control direction rather than using the constraint. Also had to reapply "Movement Basic".

Again, this method can be applied to the other weapon unusuals but takes a bit of time to redo each particle system.

CipherlockYT avatar Sep 04 '25 05:09 CipherlockYT

Valve implemented the Energy Orb fix I made during the Smissmas 2025 update and it seems to be going well, no issues. I am working on expanding the fix now to the other weapon effects and will update this thread and Valve directly once it is complete.

CipherlockYT avatar Dec 13 '25 08:12 CipherlockYT

A new solution has been sent over to Valve (Eric Smith). The fix includes partially reverting my previous submission, which caused particle desyncing issues, returning to "Constrain distance to path between two control points". Instead, this new commit simply adds a check to see whether the player is dead when emitting weapon unusuals in first person. Solves the issue for all weapon unusuals. Commit: https://github.com/ValveSoftware/source-sdk-2013/pull/1716/commits/d0799e0ca0bc42e931d3ef030c4ba6b761a7139a

CipherlockYT avatar Dec 20 '25 22:12 CipherlockYT