GameNetworkingSockets icon indicating copy to clipboard operation
GameNetworkingSockets copied to clipboard

add tests for older windows versions and fix bcrypt detection

Open malytomas opened this issue 2 years ago • 1 comments

fixes: https://github.com/ValveSoftware/GameNetworkingSockets/issues/287

some explanation: it is possible there were mistakes in older versions of windows sdk, however, this does not manifest in your tests as you are using vcpkg, which actually forces selecting latest available sdk, however this was not the default until cmake 3.27.

either way, this version with try_compile works correctly without vcpkg even with the older windows sdk.

this PR also adds more tests, specifically for both OpenSSL and BCrypt on both windows 2019 and 2022.

malytomas avatar Jul 30 '23 17:07 malytomas

I have also added tests for 32bit windows in another branch. I can add it here too, if you are interested.

malytomas avatar Jul 31 '23 09:07 malytomas