libvgm icon indicating copy to clipboard operation
libvgm copied to clipboard

Add new MAME FM cores

Open superctr opened this issue 3 years ago • 5 comments

Aaron Giles' rewrite of the old MAME FM cores was recently merged in the last MAME release.

It is supposedly more accurate than the previous cores, and also has a more liberal license (BSD-3-clause instead of GPL).

I think it would be good to include it in libvgm, although it would probably need a lot of work to remove the "C++-isms" to port it to C.

superctr avatar Mar 06 '21 04:03 superctr

I'll probably go with just porting the C++ versions over as they are. (except for making it more C++98 compatible maybe) As long as there is a C interface, I think this is fine.

ValleyBell avatar Mar 06 '21 07:03 ValleyBell

I think I prefer plain C to C++ just in order to avoid a dependency on libstdc++ and templates causing the binary size to balloon. But if you're able to avoid that, then I think it would be fine.

superctr avatar Mar 06 '21 18:03 superctr

Plain C would be my preferrence. (I recently ran into trouble with C++ libs and MSVC.) But I think just to get started, C++ would be fine as well.

ValleyBell avatar Mar 07 '21 08:03 ValleyBell

I would like to share the work I'm doing with this cores: https://github.com/LeonardoDemartino/mame_fm_bsd_cores I have extracted the main parts of the cores and removed any dependencies whatsoever with the rest of the MAME classes and structures (it was a pain to do this). YM2612, YM2151 and YM2610 are working fine.

Feel free to use it and/or improve it.

LeonardoDemartino avatar Apr 14 '21 19:04 LeonardoDemartino

By now Aaron made the cores more selfcontained: https://github.com/aaronsgiles/ymfm

toxieainc avatar May 31 '21 17:05 toxieainc