Valkyrien-Skies icon indicating copy to clipboard operation
Valkyrien-Skies copied to clipboard

[Feature Suggestion] Add config options to blacklist placeable blocks in ships

Open TheQKnight opened this issue 4 years ago • 8 comments

Right now, there is a config option to blacklist certain blocks from being included in the initial construction of the ship, but no config to blacklist the blocks that can be placed on an assembled ship after the ship has been created. I suggest adding a blacklist of blocks of which cant attach to the ship at all. This seems like an essential feature for people who might be running multiple mods that can behave incorrectly when their blocks are placed on these ships.

TheQKnight avatar Jan 03 '21 07:01 TheQKnight

It might be easier for pack developers if the same blacklist was used in both cases. Any block in the ship creation blacklist also can't be placed in ships after creation.

TheDeviantCrafter avatar Jan 05 '21 22:01 TheDeviantCrafter

what if someone wants to place stone or dirt on a ship?

deltanedas avatar Jan 06 '21 09:01 deltanedas

Good point

TheQKnight avatar Jan 07 '21 00:01 TheQKnight

I suggested this to someone in Discord earlier, you can use ForgeEssentials or another similar region management mod to prevent the creation of certain blocks. Simply target the 'shipyard' area, which is X = 5119888 to X = 5120112, and Z = -112 and higher

Rubydesic avatar Jan 07 '21 17:01 Rubydesic

Hmm interesting. I would still like to see this config option added, so I wouldn't have to add another mod into my pack to make this work.

TheQKnight avatar Jan 08 '21 00:01 TheQKnight

To avoid a bunch of copy pasting, I propose two lists:

  1. A list of blocks that can't be placed on ships when the ship is first formed.
  2. A list of blocks that can't be placed on ships when the ship is formed, but CAN after the ship is created.

That way pack developers don't need to put blocks in both lists.

TheDeviantCrafter avatar Jan 08 '21 01:01 TheDeviantCrafter

I wouldn't imagine it would be too hard to just copy-paste blocks, as the first proposed solution would probably be simpler.

TheQKnight avatar Jan 08 '21 01:01 TheQKnight

I suggested this to someone in Discord earlier, you can use ForgeEssentials or another similar region management mod to prevent the creation of certain blocks. Simply target the 'shipyard' area, which is X = 5119888 to X = 5120112, and Z = -112 and higher

I've been looking around for a while, and I can't seem to find a way to accomplish this through Forge Essentials. If you got it working this way, do you mind sharing the config? Thanks. Edit: I found out how to do it in Crafttweaker.

If anyone wants to remove certain blocks from being placed in ships with CT:

https://gist.github.com/TheQKnight/0162ffacaf644ca8468ec7838f0028d7

just replace the strings in blockedBlocks with whatever blocks you want removed.

TheQKnight avatar Jan 09 '21 00:01 TheQKnight