Valkyrien-Skies-2 icon indicating copy to clipboard operation
Valkyrien-Skies-2 copied to clipboard

Fix Compatibility with Worldgen Mods

Open Brickmaster1 opened this issue 1 year ago • 4 comments

Mod Name

Any mod that has a custom worldgen code, E.G. (Terraforged, Terra, Modern Beta, etc)

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

  • [x] I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version

1.18

Mod Loader

Forge

Issue description

Any mod that has a custom worldgen code, E.G. (Terraforged, Terra, Modern Beta, etc) gets used in ships, because the shipyard uses far away land and does not properly clear the chunks for mod support. It would be really nice if you guys could make VS check the chunk after it has been generated as an initialization action for the shipyard and if it finds any blocks before using the chunk, overwrite the chunk with air as you usually do, and then have a list of chunks that the shipyard uses, which are initialized. This would allow for you to avoid this issue with mods that heavily change the world generation code.

Issue reproduction

Download Terraforged in addition Valkyrien Skies and attempt to assemble a ship with interactive for example.

Logs

Not relevant.

Brickmaster1 avatar Feb 17 '24 02:02 Brickmaster1

Reproduce in version 1.20.1 on SkyBlockBuilder Mod, the ship will take a huge of air or water block when entity assemble, which indicates any customGen mod may cause this issue. By the way, I think it will be a bug instead compat issue.

Yorunina avatar Mar 27 '24 03:03 Yorunina

@Rubydesic @StewStrong Sorry to bother. Could you help me to check how it's going on?

Yorunina avatar Mar 27 '24 03:03 Yorunina

?

AgentMelinda avatar Sep 26 '24 15:09 AgentMelinda

@Rubydesic @StewStrong Sorry to bother. Could you help me to check how it's going on?

I encourage you make a PR with that fix. We will happily review it.

Rubydesic avatar Sep 28 '24 02:09 Rubydesic