Gyro curve / button bindings short and long press

[dkswedens]

Device manufacturer

• [ ] AYANEO
• [ ] AYN
• [ ] AOKZOE
• [X ] ASUS
• [ ] GPD
• [ ] ONEXPLAYER
• [ ] VALVE

Device model ROG Ally

Handheld Companinion Version 0.18.0.3

Describe the bug Altering the gyro curve HC occassionally crashes, more often than not. Adding a long press button in this example (xbox guide) to view button on rog ally, the short press action doesn't always register.

To Reproduce Try changing the gyro curve try different long / short press buttons and see the short press action doesnt always register

[CasperH2O]

@dkswedens thanks for reporting. Please do not create a single ticket for two different problems, that makes administration difficult.

The gyro curve will be most likely replaced/updated with the new graph that is being built for fan control.

I'll check on my ROG Ally if I can reproduce your short press action problem.

[CasperH2O]

Can't reproduce the gyro curve issue. Can reproduce the long press issue. Define a hotkey with short press (A), the try to define another hotkey with long press (A), it won't register, but trying to define again will register a short as long.

[CasperH2O]

Long press issue has been fixed.

[CasperH2O]

Reproduced gyro curve crash, used gamepad navigation to select and apply the presets.

[Valkirie]

Oh yeah, modifying the gyro array while gyro is enabled means we're trying to modify the array while it's being read. We can either set the array to some form of concurrent stuff or be smarter here.

[CasperH2O]

@Valkirie I'm tempted to leave the gyro curve crash bug for now until such a time when the cosmetic issues of the fan curve have been fixed and we can port the code and just update the UI.

Then again, I really love this type of graph and it even includes the gyro motion highlight. ❤️

[CasperH2O]

Gyro curve crash has been fixed, most likely with the MVVM update.

[CasperH2O]

As the button bindings was also fixed, I'm closing this one. Thanks for reporting these in @dkswedens