Valhelsia-Structures icon indicating copy to clipboard operation
Valhelsia-Structures copied to clipboard

[Bug]: Only 3 structures out of all are ever generated

Open celsiusqc opened this issue 2 years ago • 8 comments

Describe the issue

... For some reason, even after making another world with another seed, only 3 structures can ever be found with the locate command. Those are the desert house, spawner dungeon, and the witch hut. image

Minecraft Version

1.18.1 (Default)

Mods Version

  • Forge: 40.0.18
  • Valhelsia Structures: 0.1.0
  • Valhelsia Core: 0.3.0
  • Minecraft: 1.18.2

Log

https://gist.github.com/WelpSTudent/d47aa97e22809ca7f26ff38e281c0d3e

celsiusqc avatar Mar 22 '22 22:03 celsiusqc

Thats because of Terralith. In 1.18.2 all biomes a structure can generate in are now defined through tags so someone would need to add all Terralith biomes to the structure tags until a better solution has been found.

stal111 avatar Mar 23 '22 16:03 stal111

I'm curious, why is this not a problem with mods such as repurposed structures or other structure mods I have come across?

celsiusqc avatar Mar 24 '22 00:03 celsiusqc

Thats because of Terralith. In 1.18.2 all biomes a structure can generate in are now defined through tags so someone would need to add all Terralith biomes to the structure tags until a better solution has been found.

I also have biomes o plenty, wouldnt that allow some of your structures to spawn in those biomes because of forge dictionnary?

celsiusqc avatar Mar 24 '22 00:03 celsiusqc

I'm having the same issue! At first I thought the 1.18 generation was the problem, with the terrain being so much more varied and overall higher so i tried to switch over to 1.17.1 with no luck. The only structure i get a response from is the spawner dungeon, and whenever I put in the forge or castle, my minecraft basically freezes for 20 minutes or more (presumably searching all the chunks around) just to report that they aren't nearby. I've tried this across like 10 seeds for hours and redownloaded valhelsia structures several times to no avail. Could really use some help lol

Jushylol avatar Apr 04 '22 22:04 Jushylol

I think I found the source of the issue on my end, I will have to do some testing when getting back home. From my short test, if you have biomes o plenty installed and change a biome to off, no structures, including vanilla and modded, were spawning properly. After resetting the bop configs, all of the valhelsia structures were spawning, while having terralith installed. I have to double check though

celsiusqc avatar Apr 05 '22 20:04 celsiusqc

I have a bunch of mods enabled currently, but none of them are BOP or Terralith and None of them change world gen or anything like that. Do I need Terralith to have it work right now?

Jushylol avatar Apr 06 '22 13:04 Jushylol

Yo just an update, I'm pretty sure i figured out the problem on my end. It seems that changing the separation between structures in the config file at all causes the whole thing to bug out. Returning them to their original values has let them spawn again and everything seems normal now.

Jushylol avatar Apr 08 '22 03:04 Jushylol

Having the same issue, the problem is gone whenever i regenerate the biomes of plenty config file, but reapears when i disable the biomes i don't want

kuba26038 avatar Dec 22 '22 05:12 kuba26038