Slidy icon indicating copy to clipboard operation
Slidy copied to clipboard

@slidy/svelte: direction

Open EricRovell opened this issue 2 years ago • 5 comments

The problem

There should be an option to set a direction as boolean prop rtl as some languages have right-to-left direction. Sure, user can traverse the array of items in different direction itself, still, it is a good enhancement to implement.

The implementation

There are two options. I think, it should be implemented using new CSS Logical Properties, as it would use less code instead of just meddling with items order,

EricRovell avatar Mar 11 '22 11:03 EricRovell

Since v3.4.9 @slidy/core automated calculate direction from rendered children flow 🤓 In template just needed css rules, like: flex-flow: row-reverse, direction: rtl or html attribute on target node dir="rtl"... that's it🤷🏻‍♂️

Valexr avatar Jun 27 '22 08:06 Valexr

I feels like flex-flow: row-reverse is an odd choice here. It breaks the visual order, while direction not.

EricRovell avatar Jun 29 '22 15:06 EricRovell

What do you mean for direction ?

Valexr avatar Jun 29 '22 15:06 Valexr

I mean direction property.

EricRovell avatar Jun 29 '22 17:06 EricRovell

I mean direction property.

Ok, and what...?

Valexr avatar Jun 29 '22 17:06 Valexr

Direction control is implemented, no need for this issue anymore.

EricRovell avatar Aug 23 '22 23:08 EricRovell