TwitchDropsMiner
TwitchDropsMiner copied to clipboard
Valentin-Metz
"Minimize to Tray" not working
Great fork! Thanks for your work on this, particularly being able to do unlinked items.
Minor issue: "Minimize to Tray" function doesn't work. Likewise, when starting the miner with a minimize-to-tray switch, the tray icon never appears, instead running without any interface in the background. The only way to exit it is a force-close/taskkill.
Currently on latest commit 83104d1, built 3/8/2024.
@jaredkotoff has done improvements to the GUI before; I'm mainly running this on a server. Maybe he has some ideas on what we'd need to change for this to work. (The program just running in the background is our default intended behavior, but I see why one might still wish to have it in tray if you are using it via GUI)
First thing, does that feature work on the original project?
Just to make sure that it's actually problem introduced in changes to this fork.
@jaredkotoff Yes, minimize-to-tray does work properly in DevilXD's repo (at least last time I tried it). I can test/troubleshoot further if you have any suggestions.
@Coldblackice this doesn't work because pystray was removed from this fork
https://github.com/Valentin-Metz/TwitchDropsMiner/commit/770267140e927c64c2251fab1774a6010e856381
If you know how to code, you can probably try adding it back while making sure it doesn't break any of the headless/docker stuff and see what @Valentin-Metz says
Ah, yes, I remember it making problems. @Coldblackice if you want to add it back in, feel free to do so, but please make sure it works in the Docker container if you do.
@jaredkotoff @Valentin-Metz Thanks for the info, good to know and will do.
By chance, do you remember what problems it was causing (or at least what type)?
By chance, do you remember what problems it was causing (or at least what type)?
It was causing issues with the program starting in Docker. Either because it was outdated at the time, or because it can't handle a tray "not existing". There is probably a way to integrate it without making the entire program crash when its running in a no display environment, it simply hasn't been done yet.