windows2usb icon indicating copy to clipboard operation
windows2usb copied to clipboard

`isolabel` should be sanitized

Open b0ch3nski opened this issue 3 years ago • 4 comments

isolabel can contain chars that mkfs.vfat cannot accept

https://github.com/ValdikSS/windows2usb/blob/9f855faabd9f33998b3c773927311510877f15a6/windows2usb#L252

mkfs.vfat: Labels with characters *?.,;:/\|+=<>[]" are not allowed

b0ch3nski avatar Aug 26 '22 11:08 b0ch3nski

I assume you have a custom ISO file. Custom ISO files are generally not supported as they may contain many modifications as Windows installer system is pretty flexible, which are not handled by windows2usb.

ValdikSS avatar Sep 04 '22 21:09 ValdikSS

Agreed, but replacing the not allowed chars would be pretty much simple and protect from at least this kind of issue ;)

b0ch3nski avatar Sep 05 '22 08:09 b0ch3nski

@b0ch3nski What did you end up using to create the USB?

EDIT: Ventoy worked for me.

Manouchehri avatar Sep 14 '22 20:09 Manouchehri

@b0ch3nski What did you end up using to create the USB?

@Manouchehri Monkey-patch the code - remove these lines:

    isolabel="$(get_iso_name "$isopath")"
    if [ $? -ne 0 ]
    then
        isolabel=""
    fi

It will create the empty ISO label which will avoid the FAT32 limitations.

b0ch3nski avatar Sep 20 '22 15:09 b0ch3nski

Fixed in 0.2.2

ValdikSS avatar Dec 06 '22 23:12 ValdikSS