Dev Ojha

Results 331 comments of Dev Ojha

I insist on all new Osmosis code that we never register errors, because it is an enormous overhead / barrier to safe patch releases. I advocate for removing the sdk...

Hrmm, several tests are failing due to API rate limits? Could an admin check in on that / re-run when they get a chance? I imagine its applying to all...

ack for changing the module import path! Disagree for it not changing anything in terms of dependencies, this is on its own quite useful even under the current API, of...

- LastResultsHash: Just increment gas in some message, and attempt to replay on same network - AppHash: use random to change the value you write to a store I don;t...

We're testing what we hope to be the last fix for IAVL stability, hopefully we can work on upstreaming it after that. I think thats the only thing that can...

Iterating over items being cheaper than random reads is intentional. They maintain locality in the tree structure and therefore are cheaper to read and write from. Presumably the iterator has...

So currently iterators have a very expensive one-time-cost. I feel like its simpler to make this a cost at iterator creation time, then try to special case for next's, no?...

> AFAIK, it just calls one Next() and charges for it. Basically charges the (cheaper) price to load one item. And then again for each valid item it reads (nothing...

Yes please, lets add a notable fixed gas cost for iterator creation