Dev Ojha
Dev Ojha
> Key Format Changes Basically make key formats we write to disk follow `write_version | path_to_node` > Replace all native maps with BTree maps This is entirely unrelated > We...
Oh wow, your definitely right. Great catch!! We should add a catch for this situation here: https://github.com/osmosis-labs/osmosis/blob/3c7eab90146396d7cb5ee7f4580244be78bf44f6/x/twap/logic.go#L196-L210 I think the following should suffice ```go record, err := k.getRecordAtOrBeforeTime(ctx, poolId, t,...
Wait why? We have a test that creates a pool and asserts the equivalent desired behavior seems fine? A second test for just the method feels like extra boilerplate, for...
The idea here is that the chain governance would be forcing this, similar to how curve works. Hence its not a percent chosen by address. > > If the validator...
This is not eligible for v12 inclusion
Nah this wouldn't need a state migration, it'll only affect new records
(Had a call to rename the internal `estimate` methods to better indicate that they can really change state, and move `cacheCtx` from query into the go API for public Estimate...
I see (I missed the inner hash in the cip22 logic), totally makes sense for the double hashing paradigm! Is the inner hash relatively expensive natively as compared to signature...
Ah, that definitely makes sense for why you're doing it! Thanks for the expl. Perhaps the name `CrhAndXofHashToCurve` is more accurate?