Refactor into PyTorch BasePruningMethod ?

[tchaton]

trafficstars

Dear @VainF,

Awesome work with this library. I wondered if you could refactor your library to match prune API provided by PyTorch.

It would make integration into upstream libraries simpler.

Best, T.C

[VainF]

Hi @tchaton

Thanks for your suggestion! I will refactor the code in the following weeks.

[tchaton]

Great,

I just added PruningCallabck on PyTorchLightning. https://github.com/PyTorchLightning/pytorch-lightning/blob/release/1.2-dev/pytorch_lightning/callbacks/pruning.py#L53 Feel to make a review and ping me if something is wrong there.

Would be great to collaborate and make the callback compatible with this library. We could even contribute your work there, so thousands can use it 😁

Best, T.C

[VainF]

That sounds great! It seems feasible to add a parameter like "fix_dependency=True" to ModelPruning and run this package inside the callback. I will try it and let you know if I have some progress. BTW, it would be great to collaborate as I am not a pytorch-lightning expert. :smile:

[tchaton]

Hey @VainF,

Sounds amazing. Please, join our Slack and ping me directly :)

[codestar12]

Any progress on this? I would like to help if needed @VainF @tchaton