ngx-order-pipe icon indicating copy to clipboard operation
ngx-order-pipe copied to clipboard

Create Ivy build

Open btxtiger opened this issue 2 years ago • 14 comments

- ngx-order-pipe [es2015/esm2015] (git+https://github.com/VadimDez/ngx-order-pipe.git)
Encourage the library authors to publish an Ivy distribution.

btxtiger avatar Jan 02 '23 09:01 btxtiger

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '23 04:03 stale[bot]

@VadimDez can you have a look at the PR?

nerumo avatar Apr 26 '23 03:04 nerumo

image

Now its breaking with Angular 16. If it's not yet, just delete your node_modules folder followed by reinstalling npm and try to compile again. I'm dropping this library

btxtiger avatar Jun 26 '23 09:06 btxtiger

Anyone who have faced this same issue and found any replacement, plz do share as authors of this plugin is not publishing any update for ivy.

stormbreakR1 avatar Jun 27 '23 08:06 stormbreakR1

@stormbreakR1 is super simple to create a custom pipe and use lodash orderBy or lodash sortBy for sorting. This way you could also keep the type if you implement it as generic

btxtiger avatar Jun 27 '23 08:06 btxtiger

@btxtiger thanks

stormbreakR1 avatar Jun 27 '23 08:06 stormbreakR1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 16 '23 21:09 stale[bot]

🙏

reda-alaoui avatar Sep 17 '23 09:09 reda-alaoui

npm i ngx-pipes

hardcorelite avatar Sep 28 '23 19:09 hardcorelite

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '24 11:01 stale[bot]

still a problem

nerumo avatar Jan 07 '24 13:01 nerumo

@nerumo npm i -S lodash-es

import { Pipe, PipeTransform } from '@angular/core';
import { orderBy as _orderBy } from 'lodash-es';

@Pipe({
   name: 'orderBy',
   standalone: true,
})
export class NgxOrderPipe<T> implements PipeTransform {
   transform(data: T[], orderBy: string, direction: 'asc' | 'desc' = 'asc'): T[] {
      return _orderBy(data, orderBy, direction);
   }
}

btxtiger avatar Jan 10 '24 12:01 btxtiger

@nerumo npm i -S lodash-es

import { Pipe, PipeTransform } from '@angular/core';
import { orderBy as _orderBy } from 'lodash-es';

@Pipe({
   name: 'orderBy',
   standalone: true,
})
export class NgxOrderPipe<T> implements PipeTransform {
   transform(data: T[], orderBy: string, direction: 'asc' | 'desc' = 'asc'): T[] {
      return _orderBy(data, orderBy, direction);
   }
}

If this is the course of action you suggest, then this repository should be archived

nerumo avatar Jan 10 '24 12:01 nerumo

@nerumo This is a quickfix for most usecases. I would rather takeover this repo, since the original author is not answering anymore. However if I get some time soon, I'll otherwise create a new library for this.

btxtiger avatar Jan 10 '24 14:01 btxtiger

Fixed by version 3.0.0

VadimDez avatar May 18 '24 12:05 VadimDez