vunit icon indicating copy to clipboard operation
vunit copied to clipboard

pytest fails to check license in json-for-vhdl library

Open csantosb opened this issue 8 months ago • 1 comments

File vunit/vhdl/JSON-for-VHDL/src/Encodings.pkg.vhdl has no license heading, which produces tests/lint/test_license.py to fail.

Failed to find license notice in /tmp/guix-build-python-vunit-5.0.0-dev.5.drv-0/source/build/lib/vunit/vhdl/JSON-for-VHDL/src/Encodings.pkg.vhdl

csantosb avatar Apr 27 '25 08:04 csantosb

Those files should be skipped based on

https://github.com/VUnit/vunit/blob/4e30fa124ea84609af0f957dbc55b82adaed1d76/tests/lint/test_license.py#L148

I think it may be a consequence of running the tests from a "strange" location or running the tests from a source version and having a different VUnit version installed or something like that.

It may be "easier" to just check if JSON-for-VHDL is in the full path to the file, but there may be a reason why this slightly more advanced check is performed.

oscargus avatar May 19 '25 10:05 oscargus

I will close this issue based on @oscargus comment.

LarsAsplund avatar Jul 08 '25 09:07 LarsAsplund