crack-a-laugh icon indicating copy to clipboard operation
crack-a-laugh copied to clipboard

lights-Out challenge

Open anoura12 opened this issue 3 years ago • 2 comments

completed making a query for the data in stage 2

anoura12 avatar Mar 04 '21 18:03 anoura12

Hi, thanks for your feedback.

  1. I believe a few gaps in my Django and GraphQL knowledge was the cause of not being to complete rendering the Leaderboard component. I'll try to strengthen this aspect of the curriculum.
  2. Yeah, I think you mean by the model not being implemented in the Leaderboard component right?
  3. You can still click on the cells, but nothing is rendered after that right? I mean, nothing would get updated even if the user clicks on the cells.
  4. I'm sorry but could you clarify what PR, PR7, PR6, and PR5 refers to?
  5. Oh, I'll try fixing that.

These are a couple of doubts I wanted to clarify. In addition to this, I took a little more time than required to actually understand the code and more importantly, how to approach it. So, initially, my approach was a bit haphazard rather than systematic. I'd have to finetune that part a little more to gain some efficiency. Aside from this, even though I couldn't complete the code, I enjoyed the challenge and did manage to learn quite a lot at least in the React part of it as I didn't refer to a lot of links for this. Getting stuck in several places did benefit my learning a lot.

anoura12 avatar Mar 05 '21 06:03 anoura12

Hi, thanks for your feedback.

  1. I believe a few gaps in my Django and GraphQL knowledge was the cause of not being to complete rendering the Leaderboard component. I'll try to strengthen this aspect of the curriculum.
  2. Yeah, I think you mean by the model not being implemented in the Leaderboard component right?
  3. You can still click on the cells, but nothing is rendered after that right? I mean, nothing would get updated even if the user clicks on the cells.
  4. I'm sorry but could you clarify what PR, PR7, PR6, and PR5 refers to?
  5. Oh, I'll try fixing that.

These are a couple of doubts I wanted to clarify. In addition to this, I took a little more time than required to actually understand the code and more importantly, how to approach it. So, initially, my approach was a bit haphazard rather than systematic. I'd have to finetune that part a little more to gain some efficiency. Aside from this, even though I couldn't complete the code, I enjoyed the challenge and did manage to learn quite a lot at least in the React part of it as I didn't refer to a lot of links for this. Getting stuck in several places did benefit my learning a lot.

  1. Yes. You made the model, registered it, made the schema and added the necessary query structure. However that is all in the backend. The goal for stage 2 was to use that query to fetch data from server and display them in a nice leaderboard. You have the query but you're not doing anything with it. That's the issue.
  2. Do you know of any game that allows you to continue playing after you've lost. When you reach the end of the game, it should only show the outcome (win/lost) and the leaderboard. What you did was display the outcome at the bottom while the user could still click cells on the board, even when the number of tries has already reached zero.
  3. PR number 5, PR number 6, PR number 7 and your PR have nearly the same code for stage 1.

VSevagen avatar Mar 05 '21 09:03 VSevagen