crack-a-laugh
crack-a-laugh copied to clipboard
Completed Web challenge
Completed the web challenge. Have an extra commit at the end which is just the refactoring of the code. Previously, I had the Game logic in the Board component which then has been extracted to the App component.
@VSevagen Have you tried running python manage.py migrate
?
I have cloned a fresh version of the project to find myself with the same errors that you have mentioned. But just by migrating everything worked fine.
@VSevagen Have you tried running
python manage.py migrate
? I have cloned a fresh version of the project to find myself with the same errors that you have mentioned. But just by migrating everything worked fine.
Yes I've run migrate.
Hi there, A few issues to be noted:
- After completing the game (winning or losing), some error pop out indicating that entries is null. So mapping cannot happen
- From the server side, accessing the Entrys model yields out a "table doesn't exist error".
- From graphql, any queries or mutation is ending in an error.
- Opening the server side link yields a "Page not found" error. A default page should have been added even though we're just using the /graphql and /admin page.
I was not able to test the whole thing since everything was ending in an error. I tried adding an entry as well but even that ended in the same "Table not found" error.
I know it might be working from your side but please look into what could cause issues from users side.
Ok, turns out current build was being affected by build from previous evaluation. No idea why (was using different branch for each eval) but that seems to be the case. Like you said a fresh clone worked fine. So ignore the previous review.
Nice work on completing the challenge. Apart from that default "No page found" for "/", code is pretty clean. A little bit more effort on the styling would have been good but overall good work.
Please leave the docs/tutorials you visited to complete the challenge. Might be useful for future references.