vscodium icon indicating copy to clipboard operation
vscodium copied to clipboard

Published 20 hours ago • verified publisher icon VSCodium

Fix invalid `ProductVersion` in insider build

Open eternalphane opened this issue 2 years ago • 6 comments

When building with INSIDER=1 on windows, WIX will complain with error LGHT0204: ICE24: ProductVersion: 1.64.0-insider is an invalid version string. This pr removes the -insider suffix from ProductVersion.

eternalphane avatar Feb 02 '22 13:02 eternalphane

It is correct to don't have that in productversion, but the patch is not correct.

Can you please give it a second try to remove it from MS_TAG early on and - if it isn't part of that yet - add it to PRODUCT_NAME as "- Insiders" instead (and ensure that PRODUCT_ID is also different from the normal build [if that is a string then as "-insiders"]? This would match MS' insider build installer.

GitMensch avatar Mar 03 '22 13:03 GitMensch

and ensure that PRODUCT_ID is also different from the normal build [if that is a string then as "-insiders"]?

Seems like PRODUCT_ID should be GUID. Changing PRODUCT_NAME should be enough if insider build is not to be added to CI build.

eternalphane avatar Mar 04 '22 18:03 eternalphane

We all hope for CI insider builds, so please adjust PRODUCT_ID, too.

GitMensch avatar Mar 04 '22 19:03 GitMensch

Friendly ping @eternalphane about fixing PRODUCT_ID along this and recheck your wix build, I'll merge it afterwards.

GitMensch avatar Mar 13 '22 15:03 GitMensch

sorry. been a bit busy IRL. will take a look this weekend.

eternalphane avatar Mar 17 '22 04:03 eternalphane

sorry. been a bit busy IRL. will take a look this weekend.

No problem. Any update though?

GitMensch avatar May 19 '22 10:05 GitMensch

I've integrated the fix in #1217.

daiyam avatar Aug 24 '22 22:08 daiyam