vscodium icon indicating copy to clipboard operation
vscodium copied to clipboard

Support for Win7/8?

Open LexaGV opened this issue 1 year ago • 108 comments

I use Windows7 x64 and VSCodium WAS working on this platform. Why it doesn't work anymore? Is it possible to build Electron for Win7? Obviously there is NOTHING what Electron needs from Win10 what doesn't exist on Win7.

If it's not possible to recompile Electron, it could be nice AT LEAST keep mention of latest release which worked on Win7. Please, update README.

LexaGV avatar Sep 19 '22 19:09 LexaGV

See https://github.com/VSCodium/vscodium/issues/1256 They need to do more than 'update the readme', they need to not offer the update on Win 7. We don't need our environments seamlessly fucked.

africalimedrop avatar Sep 19 '22 19:09 africalimedrop

Waiting for https://github.com/electron/electron/issues/35597.

paulcarroty avatar Sep 19 '22 20:09 paulcarroty

I tried to find a doc for the system requirements to run electron (not to build it). I didn't found it...

daiyam avatar Sep 19 '22 20:09 daiyam

Windows 7 support is mentioned in https://github.com/electron/electron/blob/main/README.md

Under https://github.com/electron/electron/issues/35597 I have now added a question on whether there is a more formal support matrix - I couldn't find one either, you're right! It doesn't matter in this case because https://github.com/electron/electron/issues/35597 has been treated as valid anyway.

ghost avatar Sep 20 '22 16:09 ghost

It's even better news!! If Electron can (and must) run on Win7, then Codium has no problem at all to work on Win7 too! Am I right?

LexaGV avatar Sep 20 '22 23:09 LexaGV

Note that "Visual Studio Code" 1.71+ explicit does not work with Windows 7 any more, because

Microsoft ended support for Windows 7 in January, 2020 and no longer provides security updates.

If you need an installation now it is likely best to use https://github.com/VSCodium/vscodium/releases/tag/1.70.2.22230 while the upstream Electron issue is solved - and ignore any updates until this issue is closed and a follow-up release is finished.

GitMensch avatar Sep 21 '22 16:09 GitMensch

So the latest working version for Win 7 (for now) is 1.70.2.22230, well I'll note that for future reference.

ooling avatar Sep 22 '22 09:09 ooling

Guys, thanks for answer. Will Win7 info be reflected in README please? My English is far from good to do it. :)

Related "MS ended support for Win7" - sorry, how it corresponds to development?! Does your operating system gone away from SSD? Or Windows become rusty? Not. SYSTEM WORKS AS BEFORE, so please don't write stupid reasons "MS doesn't support" - nobody care of it, system works as usual and nothing prevents you from using Win7 (as I do now).

LexaGV avatar Sep 22 '22 10:09 LexaGV

... as noted in the other issue: the README says what is the current state, once the upstream Electron issue is solved there is a chance that Win7 works again. ... and how MS' take corresponds to development: they explicit made clear that they won't take any effort of supporting "Visual Studio Code" under Win 7, and as vscode is Microsoft Copyright'ed and this repo builds the underlying "vscode" where only Microsoft has commit rights the decisions of MS have quite an effect on VSCodium, too. BTW: VSCodium already provides binaries for more systems than "Visual Studio Code" does; and I personally think that this will also extend to Win 7. Let's wait on Electron changes, and keep calm until then. And of course: you are invited to help them out and once this is solved are invited to also build VSCodium on your Win7 box using this repo's build scripts and patches along with the changed version of Electron and report "first hand" - or wait a bit longer.

GitMensch avatar Sep 22 '22 11:09 GitMensch

https://github.com/electron/electron/releases/tag/v19.1.0 is out with fixed Win7 support - canb we trigger an insider build that uses this version?

GitMensch avatar Sep 24 '22 12:09 GitMensch

Ping @daiyam (I guess the published 1.72 does not use the new electron release, does it?)

GitMensch avatar Oct 06 '22 20:10 GitMensch

The 1.72.0 is using electron v19.0.17. No fix Win7, yet.

daiyam avatar Oct 06 '22 20:10 daiyam

Thanks for the quick answer. Would it be possible/reasonable to adjust this in the insider version - even if MS has not done it yet?

GitMensch avatar Oct 06 '22 21:10 GitMensch

I think it's possible.

daiyam avatar Oct 06 '22 21:10 daiyam

You can get the 1.73.0.22306 build to work on Windows 7 if you edit resources/app/out/vs/code/electron-main/main.js at position :82:51909 to replace hostname:(0,k.hostname)() to hostname:0.

AXKuhta avatar Nov 05 '22 13:11 AXKuhta

Will be happy to have VSCodium on Windows 7 too. For Microsoft it isn't functional decision, but the product one (whatever it means). Electron looks to be fixed.

Rike-cz avatar Nov 08 '22 14:11 Rike-cz

It's extremely ridiculous to see "no support for Win7" in Electron, which has PRIMARY GOAL to be "multiplatform environment" to run applications! :) What a stupid logic! "We support Linux, because we are multiplatform, but we drop support for Win7, where we originally ALWAYS WORKED, because some stupid put in sources "Win10 only" code". Viva! :) I wish to hear what Electron needs from Win10 and what doesn't exist in Win7 that they drop support for Win7.

LexaGV avatar Nov 08 '22 17:11 LexaGV

As noted above: Electron needs Windows 10 to build for Windows, because its build tools only run there; but with its September release (19.1.0) runs again on Windows 7 (not older as the used functions are just not available there). Microsoft made the decision to not care about older OS as Windows 10, because the official support for those ended already and they don't want to publish executables working there. The idea is to now use an updated version of Electron with "Windows 7 support back again" - at least with the insider version - and see where this leads.

If you could help with that by doing so locally (on a Windows10/11 machine, of course) and test and report back, that would be very useful, otherwise you'd need to wait until someone finds the time to do so (or pay a dev to do this [no, I don't have any time available and I've never built vscodium my self so far]).

GitMensch avatar Nov 08 '22 18:11 GitMensch

The latest VSCode Insiders 1.74.0 runs fine on Windows 7 if you start it from the zip file (after unpacking it of course). The exe build doesn't install on Win 7 since they blocked the installer. https://code.visualstudio.com/docs/?dv=winzip&build=insiders

lorand-horvath avatar Nov 10 '22 07:11 lorand-horvath

Interesting, then we should get that "for free" with the vscodium insider and likely both vscodium and vscode 1.74, too. I guess they mainly increased the electron dependency.

As vscodium doesn't block the installer (as far as I know, in the unlikely case this is done then this will be dropped) we should have Windows 7 installers working here with both the insider and later the release, too!

... the next thing would be getting the insider versions to build correct again https://github.com/VSCodium/vscodium/actions. @daiyam Maybe there's again the need to re-adjust the build environment with the changed dependencies (not checked, just a thought)?

GitMensch avatar Nov 10 '22 09:11 GitMensch

Yes, VSCode 1.74 Insiders bumped electron from 19.0.17 to 19.1.3, which includes the fix for Windows 7, see https://github.com/electron/electron/pull/35702

image

lorand-horvath avatar Nov 10 '22 10:11 lorand-horvath

I can confirm the fix proposed by @AXKuhta works fine on Windows 7 SP1. I am running VSCodium 1.73.1.22314.

You can get the 1.73.0.22306 build to work on Windows 7 if you edit resources/app/out/vs/code/electron-main/main.js at position :82:51909 to replace hostname:(0,k.hostname)() to hostname:0.

solmersa avatar Nov 10 '22 23:11 solmersa

@solmersa Thanks for confirming that. Some questions: Does the installer work fine on Win7? Did you only started it or already verified that editing, possibly debugging, extensions and task work fine?

So we have the insider version running on Win7 "by default" as soon as the building works again, currently has an issue with a patch; we will also have the stable version running on Win7 once 1.74 is out.

For the current available stable 1.73 (and the currently outdated->older insider version) Win7 support can be restored by adjusting that single piece of code after installation, before the first startup.

GitMensch avatar Nov 11 '22 08:11 GitMensch

@GitMensch, I tested the Python Extension, I edited, debugged with no problem, I used the zip version, no installer.

Let me know if I can assist you testing the 1.74 version. That would be great to have it working by default on Win7 again.

solmersa avatar Nov 11 '22 08:11 solmersa

@GitMensch The insiders version has been patched yesterday and has been generated this morning. But the code.iss (which generated the .exe) is requiring at least Windows 8 (https://github.com/microsoft/vscode/issues/162524#issuecomment-1272794183). That can be patched.

daiyam avatar Nov 11 '22 09:11 daiyam

@solmersa: thank you for this verification and fast response

@daiyam: the insider version was not available when writing my post, but I see it is now. Thanks. Can you please patch the installer (also for the stable version)? I think we can close this issue afterwards (even if there's still an issue with the stable version, but even this could be fixed by adding a small sed -i s'hostname:(0,k.hostname)()/hostname:0/' resources/app/out/vs/code/electron-main/main.js to the build scripts and re-trigger a stable build).

GitMensch avatar Nov 11 '22 09:11 GitMensch

The latest VSCode 1.74 Insiders just came out, the zip build works fine on Win 7 x64 - VSCodium should as well.

image

lorand-horvath avatar Nov 11 '22 10:11 lorand-horvath

I won't do sed -i s'hostname:(0,k.hostname)()/hostname:0/' resources/app/out/vs/code/electron-main/main.js since it might break something else on Windows 7 or other platforms. I will patch the code.iss so that the .exe work with Win7.

daiyam avatar Nov 11 '22 10:11 daiyam

Thanks for checking and for the upcoming code.is patch.

We'll just keep this issue open until, presumably next month, 1.74 is out; letting people know how they likely can get 1.73 to start under Win7 if they don't want to install the insiders version in the meantime.

GitMensch avatar Nov 11 '22 10:11 GitMensch

PR #1329 done

daiyam avatar Nov 12 '22 09:11 daiyam