Vim icon indicating copy to clipboard operation
Vim copied to clipboard

feat: use vscode native nav back to avoid surpurise and inconsistency

Open qazxcdswe123 opened this issue 4 months ago • 0 comments

Notice: This is more or less a BREAKING CHANGE!

What this PR does / why we need it:

  • Currently <C-o> use hand rolled track list to go back, and it breaks after mouse navigation (eg. Cmd+Click). This surprises lots of people, like https://github.com/microsoft/vscode/issues/177598
  • This PR changed the default behaviour of <C-o> to let it use workbench.action.navigateBack

Changes:

  • <C-o> now use workbench.action.navigateBack instead of hand rolled jump list, so that gd and mouse goto state are consistent.
  • <C-t> is unchanged and still use hand rolled jump list.

Which issue(s) this PR fixes

  • close: https://github.com/VSCodeVim/Vim/issues/9195

Special notes for your reviewer: This will be a breaking change but IMO it's worth it since workbench.action.navigateBack is used much more often then Vim's jump list

qazxcdswe123 avatar Sep 30 '24 08:09 qazxcdswe123