Status Bar Color Control doesn't reset its styles when unchecked

[Mi-Ski]

Describe the bug Vim: Status Bar Color Control works by overwriting workbench.colorCustomizations in the user's settings.json but it fails to reset those modifications after I turn it off by unchecking the option in vscode settings.

"workbench.colorCustomizations": { "statusBar.background": "#005f5f", "statusBar.noFolderBackground": "#005f5f", "statusBar.debuggingBackground": "#005f5f" }, ^This was not removed from my settings.json, which made the ugly color persist on every color theme after trying out the Status Bar Color Control setting.

To Reproduce Steps to reproduce the behavior:

1. Check the Status Bar Color Control setting
2. See your settings.json being overwritten in real time when using the setting
3. Turn off the Status Bar Color Control setting
4. Get stuck with the last status bar color set by VSCodeVim on every color theme until you manually delete the offending part of your settings.json

Expected behavior Status bar color returns to current color theme's default upon turning this functionality off

Environment (please complete the following information):

• Extension (VsCodeVim) version: 1.22.2
• VSCode version: 1.66.2
• OS: Windows 10 Pro

[KbyteTutu]

same issue

[KbyteTutu]

Same here, disabling/uninstalling Vim extension doesn't matter. Also those changes doesn't appear in settings.json file and changing color theme does nothing also.

Well actually these settings are in settings.json. You can find it in "workbench.colorCustomizations" option. Actually the vscode vim is just hot change "workbench.colorCustomizations" option to implement this feature. The question is, the vscodevim dont save the option before check that box and dont recover it to empty when we uncheck that box.

[darkgraycat]

I guess the reason is that user may already have some colors in "workbench.colorCustomizations". VSCodeVim ext settings should looks like

        "statusBar.background": "#005f5f",
        "statusBar.noFolderBackground": "#005f5f",
        "statusBar.debuggingBackground": "#005f5f",
        "statusBar.foreground": "#ffffff",
        "statusBar.debuggingForeground": "#ffffff"

So, just remove these lines and have a nice day!