Vim icon indicating copy to clipboard operation
Vim copied to clipboard

Published 20 hours ago • verified publisher icon VSCodeVim

Surround fixup

Open sql-koala opened this issue 3 years ago • 5 comments

What this PR does / why we need it: This deals with a few minor issues, that came up with surround rewrite.

Which issue(s) this PR fixes fixes #6812 fixes #6743 fixes #6848 fixes #7003

Special notes for your reviewer: I tested this, with the switch set, there is no map on cs and lagfree maps on c are possible.

sql-koala avatar Jul 11 '21 09:07 sql-koala

I'm looking for updates on this PR 👀

kino-ma avatar Dec 05 '21 10:12 kino-ma

Hi @J-Fields can we get this merged? The surround plugin is "broken" only for a niche group of user (custom keyboard layouts like dvorak ...) but they have no way to fix it themself. Only disable surround entirely.

sql-koala avatar Dec 21 '22 11:12 sql-koala

Hi @J-Fields I changed the flag as you suggested.

Build now fails because "prettier" on Readme.me. Can you fix that? Should be simple. I tried, but my local build setup is out of sync with this repo master.

The code itself builds and works.

sql-koala avatar Mar 28 '23 00:03 sql-koala

Any chance this could be merged? This would greatly help users of alternative keyboard layouts.

lionel- avatar Oct 14 '23 11:10 lionel-