Vim icon indicating copy to clipboard operation
Vim copied to clipboard

Tree navigation does not work

Open kryshac opened this issue 6 years ago • 35 comments

Describe the bug If we set "workbench.list.keyboardNavigation" with "filter" or "highlight" does not work as long as the vim extension is active

Screenshots without the vim extension: image

with the vim extension: image

kryshac avatar Feb 07 '19 08:02 kryshac

I'm having the same problem. And, at the moment, there seems to be no configuration option for the 'sidebar' .

SimonAKing avatar Feb 07 '19 09:02 SimonAKing

same. I thought this PR was supposed to fix this https://github.com/VSCodeVim/Vim/pull/3432

asilvadesigns avatar Feb 07 '19 15:02 asilvadesigns

Having the same issue here

RononDex avatar Feb 07 '19 15:02 RononDex

@joaomoreno

jpoon avatar Feb 07 '19 17:02 jpoon

The VIM extension defines custom keybindings for tree navigation, as always: hjkl, for example.

Because of that, you must toggle the tree filter mode. VIM configures / for that. So, you press / and then you type to filter/search, just like in VIM.

What the PR did was exactly that: it left VIM's old behavior in and allows you to use the filter feature, with the key /, since that's the least disrupting thing for VIM users.

@jpoon We might want to document this for VIM users.

joaomoreno avatar Feb 08 '19 07:02 joaomoreno

I get this as well but random. When I close and open my VS Code it sometimes works normally for me.

BosEriko avatar Feb 08 '19 08:02 BosEriko

@joaomoreno @jpoon documentation would be great, I'm still not sure if I have a problem with my setup or it just isn't working. Thanks for all the harrd work!

asilvadesigns avatar Feb 08 '19 13:02 asilvadesigns

How do I escape / filter mode and get back to hjkl? Generally I / for a file and find it, but then can't get back to regular browsing. Is esc the only option? That's okay, just a bit distant for me...

coffenbacher avatar Feb 08 '19 17:02 coffenbacher

Feel free to submit a PR updating our readme (maybe the FAQ section?). I am trying my hardest to adhere to https://twitter.com/jasonthepoon/status/1093375866929786880 :)

jpoon avatar Feb 08 '19 18:02 jpoon

I've found that search works and then stops working, same with navigation and file / folder deletion. All in all I think the new Explorer (plus VSCode-Vim) has quite a few bugs to iron out before its stable. (I ended up downgrading to November release.)

damassi avatar Feb 10 '19 22:02 damassi

A problem for me is that after using toggleVim command, the explorer sidebar still uses the vim hjkl movement shortcuts and not the highlight search. Only after manually disabling the whole extension could I get the highlight search on without needing to use the / key.

fengchaoyuan avatar Feb 11 '19 04:02 fengchaoyuan

How do I escape / filter mode and get back to hjkl? Generally I / for a file and find it, but then can't get back to regular browsing. Is esc the only option? That's okay, just a bit distant for me...

@coffenbacher as far as i can tell, it's just esc for now.

A problem for me is that after using toggleVim command, the explorer sidebar still uses the vim hjkl movement shortcuts and not the highlight search. Only after manually disabling the whole extension could I get the highlight search on without needing to use the / key.

@fengchaoyuan Yes, that is by-design. We can't disable this sort of functionality with toggleVim as it's all defined in the package.json (ie. not in the js code). I've actually been wanting to remove toggleVim, as it's a bit confusing and the implementation is incomplete, but wasn't sure if people used it. Did you have any other intentions with using it?

Again, feel free to submit a PR to add this to our docs.

jpoon avatar Feb 12 '19 12:02 jpoon

@jpoon actually I use toggleVim a lot when doing pair programming with other folks who don't use Vim Please don't remove it it's quite useful :)

jon301 avatar Feb 12 '19 17:02 jon301

I found that the issue with vim is that only shift+7 works in the explorer to activate the search.

Note that I am on a swiss-german keyboard, which has a slash on the numpad and one on shift+7. Even with vim disabled, only shift+7 works for me

RononDex avatar Feb 12 '19 17:02 RononDex

On my German keyboard I have to hit the "#" key to activate the search. "Shift+7" would have been correct ("/"), but that doesn't work on the tree, only in the editor.

quittenkaes avatar Feb 13 '19 10:02 quittenkaes

I've found that search works and then stops working, same with navigation and file / folder deletion. All in all I think the new Explorer (plus VSCode-Vim) has quite a few bugs to iron out before its stable. (I ended up downgrading to November release.)

You don't have to downgrade. Just switch workbench.list.keyboardNavigation to "simple" in settings.

wrightwriter avatar Feb 14 '19 11:02 wrightwriter

I can't get this to work with any setting. When workbench.list.keyboardNavigation set to simple, the first letter I type jumps to an item of that letter... not desirable at all, if I set it to filter or highlight anything I type is treated at a filter or highlight. I've read some people say typing / is supposed to toggle this functionality, it's not working for me, neither can I use hjkl to navigate the explorer.

asilvadesigns avatar Feb 14 '19 15:02 asilvadesigns

Just switch workbench.list.keyboardNavigation to "simple" in settings.

In my experience this is still buggy. I might need to reset some custom keybindings, but something def is up.

damassi avatar Feb 14 '19 15:02 damassi

workbench.list.keyboardNavigation "simple" is working perfectly for me. I have been using it for two days with hjkl navigation. EDIT: Too fast to answer. It's not working correctly. Especially searching is totally broken

wrightwriter avatar Feb 15 '19 10:02 wrightwriter

Same for me as for @asilvadesigns. It is said that only pressing / should toggle new quick search mode but for me it's always on. I'm using hjkl navigation in file explorer a lot, but now I cannot and this is rather frustrating.

evenfrost avatar Feb 16 '19 18:02 evenfrost

UPD: Actually it does work until I switch to Search sidebar. When I go back to File Explorer, navigation with hjkl stops working, and I have to reload window to get it back to normal.

evenfrost avatar Feb 16 '19 19:02 evenfrost

@asilvadesigns @evenfrost What versions of Code and Vim extension do you have installed?

joaomoreno avatar Feb 18 '19 09:02 joaomoreno

@joaomoreno thanks for looking into this: VS Code: Version 1.31.1 (1.31.1) Vim Extension: 1.0.8

asilvadesigns avatar Feb 19 '19 16:02 asilvadesigns

@joaomoreno Same for me.

evenfrost avatar Feb 19 '19 17:02 evenfrost

I could repro that after a while, the toggle mode stops working! :thinking: Fix coming!

Repro:

  1. Open Explorer
  2. Open Search
  3. Open Explorer again, :bug:

joaomoreno avatar Feb 20 '19 08:02 joaomoreno

Pushed fix on VS Code side. Unfortunately you're going to have to wait for the next Stable or simply get tomorrow's Insiders!

joaomoreno avatar Feb 20 '19 09:02 joaomoreno

There remains a bug: pressing L doesn't open folders in VsCode Version 1.32.1 Is this fixable via some configuration ?

leoparis89 avatar Mar 08 '19 12:03 leoparis89

@leoparis89 What VIM extension version do you have installed?

joaomoreno avatar Mar 11 '19 13:03 joaomoreno

I'm having the same issue as @leoparis89 right now. Pressing J closes the folder but L doesn't open folders.

Also, there are times that the VIM navigation on explorer does not work at all. Only fix I have for it is to restart VSCode itself.

My VIM extension version is 1.1.0. MY VSCode version is 1.32.2.

BosEriko avatar Mar 15 '19 06:03 BosEriko

L doesn't open folders.

Yup, that seems to be a new bug: https://github.com/Microsoft/vscode/issues/70681

Also, there are times that the VIM navigation on explorer does not work at all. Only fix I have for it is to restart VSCode itself.

Can you try to reproduce this situation?

joaomoreno avatar Mar 18 '19 07:03 joaomoreno