Vim
Vim copied to clipboard
VSCodeVim
`S`/`cc` doesn't auto indent on empty line
When your in Normal mode and your on an empty line and the cursor is at the very left, pressing 'S' in normal Vim auto indents the line and goes into insert mode, but VS Vim doesn't seem to indent at all.
Technical details:
- VSCode Version: 1.6.1
- VsCodeVim Version: 0.4.0
- OS: OSX El capitan
What happened:
- Typing cc when cursor is at col 0 and in block on empty line: Jumping to input mode, but won't indent correctly
- Typing cc when cursor is at col 2 (or any col): Removes line and ends up at col 0 with no indentation
- Typing cc when cursor is at col 0 but there is valid code on line that is inside a block: Removes line as it should do, but cursor ends at col 0 with trailing whitespace
- Typing cc when cursor is at col >2 (in block, line with valid code, cursor on code): Removes line of code and indents correctly ✅
Here all of those scenarios in a GIF (with tab width of 3 instead of 2)
Contributed by @lumio at https://github.com/VSCodeVim/Vim/issues/1828.
What did you expect to happen: Typing cc will always clear the line, indents it and cursor jumps to end of line.
How to reproduce it: See above, but typically typing cc on different col positions.
Nice catch, if the cursor is at somewhere between first char or last char, S works as expected but doesn't work if it's at the beginning of the file.
Not sure for what reason cursor updating in commands which invoke delete no longer works, I saw this commit change https://github.com/VSCodeVim/Vim/commit/3dad7cab1d09704c85824b726d9769a71be12817#diff-7addcd1a8a241060a73b1fe4abb39960R1269 so @johnfn might have an idea about that.
I take a quick look but now I'm confused, take S for example, if we want to control the cursor position after running delete operator, how can we do that? delete operator is now a postponed action.
@rebornix we use PositionDiffs now. We have a "beginning of line" position diff that just tells the cursor to go to the beginning of the line after the transformation is applied. We use that a few times...
This problem is fixable once the "reindent a selection" command is added, per https://github.com/Microsoft/vscode/issues/19847#issuecomment-277348907
@xiluo58 That's an interesting idea actually. To be clear to anybody who was confused as me, he's suggesting ddO.
That works for me!
"vim.insertModeKeyBindings": [{
"before": ["j", "k"],
"after": ["<Esc>"]
}, {
"before": ["c", "c"],
"after": ["d", "d", "O"]
}],
It would still definitely be nice to see the default behavior fixed.
EDIT: Actually it seems like this doesn't work, seeing as though it's an insert mode key binding. I tried otherModesKeyBindings and it doesn't seem to work there.
Any progress on this?
ddO sadly isn't a universal workaround either. For example, it won't work on the last line of a file.
ddO on c:
a
b
c
Produces
a
_
b
Also doesn't work when single line is indented:
ddO on b:
a
b
c
Produces:
a
_
c
I agree a proper indentation should be performed of the lines. This temporary fix seems to work for me. But the previous problems by @alexozer still apply.
"vim.otherModesKeyBindings": [
{
"before": ["c", "c"],
"after": ["d", "d", "d", "O"]
}
],
Not sure why the third "d" is necessary.
Hitting Tab after cc seems to do the right thing every time.
Is there a way to automate this?
@shaunlebron Take something like
asd|f
where there's 2 spaces before the asdf. Presing cc takes you to
|
and a tab adds 2 more spaces, which is not the right thing.
Another problem with remapping to ddO is that for isolated lines (single lines with whitespace immediately above and below), there is no preceding line to base indentation off of, and so O creates the new line above with no indentation. For instance consider the following Python code:
def f(): # next line intentionally left blank
ret|urn # | represents the cursor
In vim, cc would clear the line and place the cursor at the correct indentation (four space from the left margin, in this example). But in VSCode Vim, since there's no line above return to base indentation off of, it clears the line and places the cursor at the beginning of the line (outside the function body).
Python isn't the easiest language to infer desired indentation, but when the desired indentation is already given, it should be respected when using cc -- independent of any VSCode capabilities or settings.
That said, I think a better temporary keybinding for a single cc would be ^C. However that's not easily repeatable -- 5cc is not achievable by repeating ^C
Sorry to revive such an old thread - but is this really not solved yet? In python it's really annoying and given the love python gets elsewhere in vscode, this appears a bit strange.
@rben01 s workaround of using ^ C works best for me. So much that I'd like to remap it actually, but that doesnt work either:
"vim.normalModeKeyBindings": [
{
"before": [
"c",
"c"
],
"after": [
"^",
"C"
]
}
]
Somebody got a better idea?
There's nothing we can do about this - it's an upstream problem. After a command like cc, we run editor.action.reindentselectedlines, which requires indentation rules to be specified for the current language to work correctly.
Seems like these are relevant issues. Go upvote them please! Python: https://github.com/microsoft/vscode-python/issues/8996 C++: https://github.com/microsoft/vscode-cpptools/issues/883
How about using some kind of workaround until it's fixed properly upstream? It's a very annoying problem and I don't think it's good for the end user to just shove it under the rug waiting for it to potentially be fixed someday somewhere else. Like, O action for example could be implemented just by doing end+enter macro or something like that.
Hi I have Visual Studio Code 1.43.2, vim extension 1.13.1.
I cannot remap cc, is it also a known bug?
I've included the following chunk in my settings.json, "leader, m" works, but the cc remap does not.
"vim.normalModeKeyBindings": [
{
"before": [ "c", "c" ],
"after": [ "^", "C" ],
},
{
"before": [ "<leader>", "m" ],
"commands": [ "bookmarks.toggle" ]
},
{
"before": [ "<leader>", "b" ],
"commands": [ "bookmarks.list" ]
}
]
This is frustrating, especially when I see this issue was raised in the year of 2016, and now it's 2020.
@zeroxia see https://github.com/VSCodeVim/Vim/issues/4464#issuecomment-577246612
I agree, it's frustrating, but then this is open source...
Have that problem with C#. "Reindent selected lines" does not work for it, but indent adds when use "o". So I made that workaround. But it only works if upper line not empty too.
"vim.normalModeKeyBindingsNonRecursive": [
{
"before": ["S"],
"after": ["d", "d", "g", "k", "o"],
},
],
Such kind of key binding works well indeed.
However, it now makes u confuse me. It considers the combination as the combination itself, so I need to undo for 3 times.
I think an update to implement a real S should be better indeed.
offer a workaround for "o", which I use frequently:
"vim.normalModeKeyBindingsNonRecursive": [
{
"before": [
"o"
],
"after": [
"o", "_",
],
"commands":[
"editor.action.formatSelection",
"deleteLeft",
]
},
I have noticed something. "cc" does not automatically indent, while "o" and "O" do, at least most of the time. Therefore, a fix should be possible without upstream/vscode, or not?
@sql-koala Is this still an issue? Because I can't reproduce this. Both cc and S auto indent for me, even on empty lines.
Indentation after both o (editor.action.insertLineAfter) and cc (editor.action.reindentselectedlines) is determined by the language support, but they're specified differently, so some language plugins support the former better than the latter. Maybe some supports the latter better than the former, but none that I've found.
I write C++ and python for my job and o works great while cc doesn't in both of these. Typescript and rust, however, both work as expected.
@J-Fields Which part of the language support handles this indentation? Is it the TextMate grammar, the formatter, the language-configuration.json or even something else?
There are many languages (like Swift) which currently aren't supported very well by S/cc either and I would like to help improve support for those.
remapping cc to ddko seems to work. It seems that o formats differently from O. There might be exceptions though.
I've been looking for answers to this for a while, and it's still broken. There are workarounds that get close, but no perfect solutions yet. The main thing I want is for cc<escape> to remove any indentation as it does in Vim, and none of the workarounds I've found achieve this.
