vroom-frontend icon indicating copy to clipboard operation
vroom-frontend copied to clipboard

Incompatibility with the latest stable version of Leaflet 1.9.1

Open egofer opened this issue 2 years ago • 1 comments

Running npm install installs the latest stable version of Leaflet 1.9.1. This gives problems when running vroom-frontend, showing the error:

Uncaught TypeError: L.hasOwnProperty is not a function

If Leaflet is downgraded to the previous stable version 1.8.0 in the package.json file, the error disappears.

egofer avatar Sep 30 '22 09:09 egofer

Thanks for reporting. Our package.json setup does not pin to a given Leaflet version but uses "compatible with 1.3.4":

https://github.com/VROOM-Project/vroom-frontend/blob/2f5484661685dd383e6c5a914f8527b14a8eb774/package.json#L34

If the compatibility is broken when moving from 1.8.0 to 1.9.1, then this sounds more like an upstream semver problem to me.

In any case, we could probably do with a round of dependency updates here, happy to look at any PR heading this way.

jcoupey avatar Sep 30 '22 09:09 jcoupey