ultimatexr-unity icon indicating copy to clipboard operation
ultimatexr-unity copied to clipboard

Hitquad wrong when using controller models

Open KlingOne opened this issue 2 years ago • 2 comments

Hi,

I noticed that the hitquad gets rendered at the wrong location when using controller models with a custom forward transform. This happens because the forward transform used to calculate the hitquad never gets updated when a controller is activated

I fixed it like this in my fork but since I changed some other things in the LaserPointer I did not want to open a pullrequest. And maybe there also is a cleaner way to implement it which does not include checking the parent transform all the time https://github.com/KlingOne/ultimatexr-unity/commit/fb3947ce6e5842aec871f9df64b6f9df6b0dbdd7

KlingOne avatar Sep 01 '23 10:09 KlingOne

Hi @KlingOne,

Thanks for reporting. I will compute the hit in LaserTransform local coordinates to avoid re-parenting, but your way should also work :)

entromp avatar Dec 01 '23 09:12 entromp

Should be fixed in #57

entromp avatar Dec 01 '23 10:12 entromp