noverify icon indicating copy to clipboard operation
noverify copied to clipboard

Invent new dynamic rules and try them out on open source projects

Open quasilyte opened this issue 4 years ago • 1 comments

This is an issue that should be referenced when sending the PR that fixes the problem found by the proposed diagnostic.

  • offBy1 https://github.com/Wikia/app/pull/18119 (open)
  • argsOrder https://github.com/composer/composer/pull/9154 (merged)
  • argsOrder https://github.com/joomla/joomla-cms/pull/30489 (already was reported, closed)
  • https://github.com/owncloud/core/pull/37858 (closed)

quasilyte avatar Aug 26 '20 10:08 quasilyte

Some relatively worthwhile ideas that are not incorporated yet.

/**
 * @maybe can use string indexing to get a single-byte substring
 * @fix   $s[$i]
 */
substr($s, $i, 1);

/**
 * @maybe could use time() instead
 * @fix   time()
 */
strtotime('now');

quasilyte avatar Aug 27 '20 13:08 quasilyte